Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86387
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c89oL54vo556WMtuZKPZu_5WkL1AHt=RFS__Kdwt1X4Rg@mail.gmail.com>
References: <CAF+90c89oL54vo556WMtuZKPZu_5WkL1AHt=RFS__Kdwt1X4Rg@mail.gmail.com>
Date: Mon, 25 May 2015 20:53:49 +0200
Message-ID: <CAF+90c-ALfv+V_yssrdBhY-y1Ce=inK3wo3g_QgX9XhM3VJNcw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134cc28c0b0550516ec87ba
Subject: Re: Exception message cleanup
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1134cc28c0b0550516ec87ba
Content-Type: text/plain; charset=UTF-8

On Thu, Apr 9, 2015 at 10:04 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> A lot of people have been confused about engine exceptions currently
> displaying as normal fatal errors (if they aren't caught). We'll have to
> change this to use exception messages.
>
> Before doing this I'd like to clean up the messages a bit to make them
> more friendly for CLI usage. Currently the messages are so cluttered that
> it's hard to find the actual error message if you're in an 80 char window.
>
> Patch is here: https://github.com/php/php-src/pull/1226
>
> Previous message:
>
> Fatal error: Uncaught exception 'UnexpectedValueException' with message
> 'Failed to open directory ""' in %s:%d
> Stack trace:
> #0 %s(%d): DirectoryIterator->__construct('\x00/abc')
> #1 {main}
>   thrown in %s on line %d
>
> New message:
>
> UnexpectedValueException: Failed to open directory "" in %s on line %d
> Stack trace:
> #0 %s(%d): DirectoryIterator->__construct('\x00/abc')
> #1 {main}
>
> Essentially exceptions would display like ordinary error, but with "Fatal
> error" / "Warning" / ... replaced by the exception name, and showing a
> stack trace after the error.
>
> A side-effect of the change is that uncaught exceptions will always be
> displayed canonically and not based on __toString output. To modify display
> of exception output, people should modify the respective properties of the
> exception.
>

An update on this:

EngineException and TypeException now display as normal exceptions
(including stack trace). ParseException still show as a "Parse error". I
don't plan to change that one.

Instead of the relatively aggressive message changes described above I've
only landed a small tweak (see
https://github.com/php/php-src/commit/3ae995f03c8f60c4a4c9718262545cf5a6a08da3),
which fixes the problem with nested quotes but keeps current structure.

Nikita

--001a1134cc28c0b0550516ec87ba--