Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86300
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAFMT4NoA10O0D5Rt3ZFPnCJ=3bEJwKxcs9J0YuZjEMbUTQ_-MA@mail.gmail.com>
References: <CAF+90c8nqCBGWpsqdfy+EKekOm3Cw5_zzE_nKeyLK5pzROTueg@mail.gmail.com>
 <550DA4EE.2030903@php.net> <55410973.4010300@php.net> <55417C64.7000707@gmail.com>
 <5541B4D6.9060503@php.net> <CAMUwpuTQ7pypMGtVvG8Uc058a3EnqTry_ss6ovZMLzg=tHGoJQ@mail.gmail.com>
 <55425D7E.6010803@gmail.com> <FE2BD464-5B2A-482B-9E84-F0CC65B52526@heroku.com>
 <554D8F4D.9020903@gmail.com> <554D90CC.3040607@php.net> <5552E3EB.5010800@gmail.com>
 <5552E494.5070401@php.net> <CAEZPtU7=6TdFt_px6uVK_LuWQ_tdF-=fKS3S-xrRXxaS9cEvdQ@mail.gmail.com>
 <5552FF58.8070807@php.net> <CAB6YZuxf1a_rEEiuGSaYht=pwGZEunU4Hanr9c8M75pafQmocw@mail.gmail.com>
 <CAFMT4NoRdxUeraGn-1VtUSK_sHm5b=yAaVrOCf_vKqHTEUi6qw@mail.gmail.com>
 <55575DCF.50801@gmail.com> <CAFMT4NpKPvRhcR+j22sWurZYnF1QJt-wj2QNsQiTo9NuCnJidg@mail.gmail.com>
 <55578C61.3040408@gmail.com> <CAFMT4Nq7LXR16Mz-+h5tv9x82bbcTqdGhaKWT=CuoPQSEAc-aQ@mail.gmail.com>
 <555796C0.2020002@gmail.com> <CAFMT4Nq9v2Jy+SDr=smUiSnVgEds9vnzNr3GVVNMyMPBu+pb-A@mail.gmail.com>
 <5557A5C6.5050701@gmail.com> <CAFMT4NoA10O0D5Rt3ZFPnCJ=3bEJwKxcs9J0YuZjEMbUTQ_-MA@mail.gmail.com>
Date: Tue, 19 May 2015 18:44:30 +0900
Message-ID: <CAGa2bXbPsdAAx0+Sq=9NJaiNHw-GD4miYtwb3rp=x17Ze9xkkw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Rowan Collins <rowan.collins@gmail.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e015375009eae7405166c2a51
Subject: Re: [PHP-DEV] [VOTE] Exceptions in the engine
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--089e015375009eae7405166c2a51
Content-Type: text/plain; charset=UTF-8

Hi all,

On Sun, May 17, 2015 at 8:44 AM, Levi Morrison <levim@php.net> wrote:

> On Sat, May 16, 2015 at 2:17 PM, Rowan Collins <rowan.collins@gmail.com>
> wrote:
> > On 16/05/2015 20:15, Levi Morrison wrote:
> >>
> >> The difference is that as time goes on and I've written code for PHP 7
> >> I was hit by this issue. It's an even bigger issue than even I
> >> realized during voting. How many people who voted on that issue have
> >> played with the code from both scenarios? Few, I can't guarantee it
> >> but given the historical precedent it's almost certainly true.
> >
> >
> > Can you give an example of the issue you were hit with? A sample program
> /
> > scenario, where failure to catch an EngineException caused behaviour that
> > was in some way worse than that under PHP 5?
>
> Here's a simplified example that illustrates one issue:
>
> <?php
>
> set_error_handler(function(){
>     echo "Handled.";
> });
>
> function foo(callable $f) {}
>
> try {
>     foo("bar is not callable");
> } catch (Exception $e) {
>     echo "Caught.";
> }
>
> echo "Done.", PHP_EOL;
>
> ?>
>
> In PHP 5 this prints "Handled.Done". Under PHP 7 this fails with:
>
> > Fatal error: Argument 1 passed to foo() must be callable, string given
>
> Note that if the TypeException had been caught by catch (Exception $e)
> the program would have still been correct. This kind of setup exists
> in PHPUnit for example; even if the test has some bad syntax or
> failure the testing harness needs to continue. There are other valid
> uses as well.
>
> The only way to make this work in both PHP 5 and 7 is to modify the
> code, despite the program being 100% correct under PHP 5 and the
> documented semantics.


We should consider internal function error/exception also.
New ZPP raises type error.

<?php
mt_srand('999999999999999999999999999');
mt_rand(0, 100);
?>

produces E_WARNING

Warning: mt_srand() expects parameter 1 to be integer, string given in - on
line 2

If we are going to break codes, it is better to break code consistently.
Is it possible treat each line enclosed by try {}? e.g.

<?php
try {
  mt_srand('999999999999999999999999999');
} catch (WhateverException $e) {
  // do something useful
}
try {
  mt_rand(0, 100);
} catch (WhatEverException $e) {
  // do something useful
}
?>

rather than

<?php
try {
  mt_srand('999999999999999999999999999');
  mt_rand(0, 100);
} catch (WhateverException $e) {
  // do something useful
}
?>

For example,

set_exception_handler(callback $callback [, bool $single_line_try_block =
FALSE])


Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--089e015375009eae7405166c2a51--