Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:86286 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23742 invoked from network); 17 May 2015 05:25:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 May 2015 05:25:11 -0000 Authentication-Results: pb1.pair.com smtp.mail=aaron@icicle.io; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=aaron@icicle.io; sender-id=pass Received-SPF: pass (pb1.pair.com: domain icicle.io designates 199.38.81.6 as permitted sender) X-PHP-List-Original-Sender: aaron@icicle.io X-Host-Fingerprint: 199.38.81.6 mercury.negativeion.net Received: from [199.38.81.6] ([199.38.81.6:63654] helo=mercury.negativeion.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 43/85-14891-63628555 for ; Sun, 17 May 2015 01:25:10 -0400 Received: from localhost (localhost [127.0.0.1]) by mercury.negativeion.net (Postfix) with ESMTP id 6CD34254A17F for ; Sun, 17 May 2015 01:25:07 -0400 (EDT) X-Virus-Scanned: amavisd-new at negativeion.net Received: from mercury.negativeion.net ([127.0.0.1]) by localhost (mercury.negativeion.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kqgKGVYXB42M for ; Sun, 17 May 2015 01:25:05 -0400 (EDT) Received: from mars.local (unknown [173.225.150.231]) by mercury.negativeion.net (Postfix) with ESMTPSA id 885A8254A166 for ; Sun, 17 May 2015 01:25:05 -0400 (EDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_2D93EA7D-14CA-43CC-8E60-B0C5EC91644A" Message-ID: <7558EA93-88B6-4F1C-9CE9-64CF0020A809@icicle.io> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Date: Sun, 17 May 2015 00:25:05 -0500 References: <5558192C.3070504@gmail.com> To: internals@lists.php.net In-Reply-To: <5558192C.3070504@gmail.com> X-Mailer: Apple Mail (2.2098) Subject: Re: [PHP-DEV] Re: Throwable patch(es) and finalizing the story From: aaron@icicle.io (Aaron Piotrowski) --Apple-Mail=_2D93EA7D-14CA-43CC-8E60-B0C5EC91644A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Submitted the pull request: https://github.com/php/php-src/pull/1284 = I=E2=80=99m not 100% sure on using the name Error, but Java uses a = similar name scheme, so it isn=E2=80=99t without precedent and it keeps = the names shorter. I also have a branch that prevents user space code from instigating = Error so only the engine can throw Errors. I wasn=E2=80=99t sure if this = was desired behavior so I left it out of the PR for now. (Sorry for originally sending this to you directly Stas, I=E2=80=99m new = to the list and thought I could just hit reply.) > On May 16, 2015, at 11:29 PM, Stanislav Malyshev = wrote: >=20 > Hi! >=20 >> I=E2=80=99ve made another version that I believe is what Sebastian = intended >> in the first place: Throwable as an interface, with Exception and >> Error being separate classes. Throwable is implemented to prevent >> user-land code from implementing it. >>=20 >> https://github.com/trowski/php-src/tree/throwable-interface >=20 > Thanks! >=20 >> Should I just submit that as a separate pull on GitHub and we can >> discuss it? >=20 > Yes, please do. Having multiple pulls in github is no problem, we'll > close them once we're done. >=20 > --=20 > Stas Malyshev > smalyshev@gmail.com >=20 > --=20 > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >=20 --Apple-Mail=_2D93EA7D-14CA-43CC-8E60-B0C5EC91644A--