Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86284
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 93.190.64.238 as permitted sender)
Message-ID: <55582210.9060908@php.net>
Date: Sun, 17 May 2015 07:07:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <5557AF50.3060203@gmail.com>
In-Reply-To: <5557AF50.3060203@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Throwable patch(es) and finalizing the story
From: sebastian@php.net (Sebastian Bergmann)

On 05/16/2015 10:57 PM, Stanislav Malyshev wrote:
> I am assuming we have broad consensus about the move from BaseException
> to Throwable. I've looked at the patch at
> https://github.com/php/php-src/pull/1282 and it seems pretty close to
> what we want to me. The only difference is that
> https://wiki.php.net/rfc/throwable says Throwable is an interface and
> this patch makes it abstract class

 It is supposed to be an interface. It it's not then it's a mistake in the
 patch.

 I strongly believe that the hierarchy for exceptions thrown by the
 engine must be separate from the hierarchy for exception thrown by
 userland code (and "regular" extensions such as Reflection, etc.).
 The whole purpose of the Throwable interface is to mark objects of
 both hierarchies as throwable.

 Whether we name the base class of the hierarchy for exceptions thrown
 by the engine Error or EngineException, I don't really care. But Error
 feels more right to me than EngineException. I do care, though, about
 the fact that userland code (and "regular" extensions such as Reflection,
 etc.) must not throw engine exceptions.