Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:86265 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74215 invoked from network); 16 May 2015 20:58:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 May 2015 20:58:01 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.51 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.51 mail-pa0-f51.google.com Received: from [209.85.220.51] ([209.85.220.51:35213] helo=mail-pa0-f51.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 07/5D-14891-85FA7555 for ; Sat, 16 May 2015 16:58:01 -0400 Received: by pacwv17 with SMTP id wv17so81062842pac.2 for ; Sat, 16 May 2015 13:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=1W9SoCVBJ3LAY9lydbwYxksmHUaI7kLGwrDNlv0Nme4=; b=C8wqdhKxutplT2l7b/Gy9NsKYNuDvbeRWtZ7wwvLTOwKVRvZht05T4LADQpSix1F04 EQnxzFOjGurzNwEYLr4EYkzC/wVRX1rr1e7g4nfDn45z1+K2Qcv+bmOWke1SoUTRz+ZA DTrKFhu3ABMwZE9t8GOhQrRMHiqlf2pLFu4ygT7uUnd8QPrkbho3M/zxGME9qxJg8W8r qNd0R5bapNvuhew4MBQmWQBiwLiYhR1hiHmzwW2Blb82j2woVI5RfqQTiEDwzulBzh8j uVMDQDM7+JwE3RbTpWGfD8e/4HKYBcVVAxUtw9ZWg1euTGDxkM4iKRHTrAk7d4DcJmQN IPlw== X-Received: by 10.66.186.103 with SMTP id fj7mr20774726pac.132.1431809877791; Sat, 16 May 2015 13:57:57 -0700 (PDT) Received: from Stas-Air.local (108-66-6-48.lightspeed.sntcca.sbcglobal.net. [108.66.6.48]) by mx.google.com with ESMTPSA id mt11sm5573159pbc.20.2015.05.16.13.57.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 May 2015 13:57:57 -0700 (PDT) Message-ID: <5557AF50.3060203@gmail.com> Date: Sat, 16 May 2015 13:57:52 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: PHP Internals , Sebastian Bergmann Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Throwable patch(es) and finalizing the story From: smalyshev@gmail.com (Stanislav Malyshev) Hi! I am assuming we have broad consensus about the move from BaseException to Throwable. I've looked at the patch at https://github.com/php/php-src/pull/1282 and it seems pretty close to what we want to me. The only difference is that https://wiki.php.net/rfc/throwable says Throwable is an interface and this patch makes it abstract class - which I guess makes some sense as both Exception and engine errors need the same properties - but I'm not sure if it doesn't mess something up. Sebastian, could you comment on this? Of course, other comments are welcome too. There's a question left about the naming - particularly, renaming EngineException to Error. I'm not sure I am a fan of this. I think it's better to leave it as EngineException, but I'm open to arguments here. One thing seems to be clear though - a) there's a broad support for introducing Throwable and b) we need to do this before we release PHP 7 alpha. So I think we need to start converging on something really soon. I'd like to take https://github.com/php/php-src/pull/1282 as a baseline, and once we close open questions about interface/abstract class and the name of the Error class, merge it - targeting sometime within the timeframe of the next week. If someone thinks it's impossible or should not be done, please tell. -- Stas Malyshev smalyshev@gmail.com