Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.179 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAB6YZuxf1a_rEEiuGSaYht=pwGZEunU4Hanr9c8M75pafQmocw@mail.gmail.com>
References: <CAF+90c8nqCBGWpsqdfy+EKekOm3Cw5_zzE_nKeyLK5pzROTueg@mail.gmail.com>
	<54F07FC7.8050901@php.net>
	<54F0839C.3010700@seld.be>
	<55052FAD.6090608@php.net>
	<5505346D.7020700@php.net>
	<550DA4EE.2030903@php.net>
	<55410973.4010300@php.net>
	<55417C64.7000707@gmail.com>
	<5541B4D6.9060503@php.net>
	<CAMUwpuTQ7pypMGtVvG8Uc058a3EnqTry_ss6ovZMLzg=tHGoJQ@mail.gmail.com>
	<55425D7E.6010803@gmail.com>
	<FE2BD464-5B2A-482B-9E84-F0CC65B52526@heroku.com>
	<554D8F4D.9020903@gmail.com>
	<554D90CC.3040607@php.net>
	<5552E3EB.5010800@gmail.com>
	<5552E494.5070401@php.net>
	<CAEZPtU7=6TdFt_px6uVK_LuWQ_tdF-=fKS3S-xrRXxaS9cEvdQ@mail.gmail.com>
	<5552FF58.8070807@php.net>
	<CAB6YZuxf1a_rEEiuGSaYht=pwGZEunU4Hanr9c8M75pafQmocw@mail.gmail.com>
Date: Sat, 16 May 2015 08:40:35 -0600
Message-ID: <CAFMT4NoRdxUeraGn-1VtUSK_sHm5b=yAaVrOCf_vKqHTEUi6qw@mail.gmail.com>
To: =?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>
Cc: Sebastian Bergmann <sebastian@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE] Exceptions in the engine
From: levim@php.net (Levi Morrison)

I want to talk about the BC impact of what has been discussed.

Currently the meaning of this code is to catch all possible
exceptions, because all exceptions *must* extend `\Exception`:

    } catch (Exception $e) {

By making some other root exception you just broke all the code that
is *appropriately* using the catch-all variant.

So either way it is a BC break. So let's consider other impact to help decide:

If we introduce a new root exception then the people "punished" are
the ones currently using Exception correctly. Whereas if engine
exceptions just extend Exception then the people "punished" are the
ones using it inappropriately.

Please, revert all of these changes with Error and some new root
exception and *do the right thing* based on logical arguments. It
makes no sense to punish the people using code correctly to avoid
punishing people misusing a feature, especially when it is a BC break
either way.