Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86223
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5552FF58.8070807@php.net>
References: <CAF+90c8nqCBGWpsqdfy+EKekOm3Cw5_zzE_nKeyLK5pzROTueg@mail.gmail.com>
	<54F07FC7.8050901@php.net>
	<54F0839C.3010700@seld.be>
	<55052FAD.6090608@php.net>
	<5505346D.7020700@php.net>
	<550DA4EE.2030903@php.net>
	<55410973.4010300@php.net>
	<55417C64.7000707@gmail.com>
	<5541B4D6.9060503@php.net>
	<CAMUwpuTQ7pypMGtVvG8Uc058a3EnqTry_ss6ovZMLzg=tHGoJQ@mail.gmail.com>
	<55425D7E.6010803@gmail.com>
	<FE2BD464-5B2A-482B-9E84-F0CC65B52526@heroku.com>
	<554D8F4D.9020903@gmail.com>
	<554D90CC.3040607@php.net>
	<5552E3EB.5010800@gmail.com>
	<5552E494.5070401@php.net>
	<CAEZPtU7=6TdFt_px6uVK_LuWQ_tdF-=fKS3S-xrRXxaS9cEvdQ@mail.gmail.com>
	<5552FF58.8070807@php.net>
Date: Thu, 14 May 2015 21:20:27 +0200
Message-ID: <CAB6YZuxf1a_rEEiuGSaYht=pwGZEunU4Hanr9c8M75pafQmocw@mail.gmail.com>
To: Sebastian Bergmann <sebastian@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [VOTE] Exceptions in the engine
From: pajousek@gmail.com (=?UTF-8?Q?Pavel_Kou=C5=99il?=)

On Wed, May 13, 2015 at 9:38 AM, Sebastian Bergmann <sebastian@php.net> wrote:
> Am 13.05.2015 um 08:30 schrieb Pierre Joye:
>> Why don't you do it? You have access and you are a very good writer.
>> No big C knowledge required either in this case :)
>
>  There was/is consensus on what I proposed back in February:
>
>    * Introduce a Throwable interface
>    * Let Exception implement the Throwable interface
>    * Introduce an Error class that implements the Throwable interface
>    * Use Error class as base class for exceptions raised by the engine
>
>  But as simple as the above sounds it is complicated (at least for
>  me) to implement (properly). Here's what I was able to come up with:
>
>    https://github.com/php/php-src/pull/1274
>
>  This should give us the following:
>
>    interface Throwable {}
>    abstract class BaseException implements Throwable {}
>    class Exception extends BaseException {}
>    class Error extends BaseException {}
>    class EngineError extends Error {}
>    class ParseError extends Error {}
>    class TypeError extends Error {}
>
>  I am not sure whether we still want the abstract BaseException
>  class. I left it in because I couldn't figure out how to remove
>  it without breaking Exception and Error.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Hello,

I personally dislike the BaseException. Does it have to be there?

If it's just for sharing some behavior between Exception and Error,
wouldn't trait be an acceptable (but definitely not perfect) solution?

Regards
Pavel Kouril