Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86211
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXY-cZ1teS9F64rzYhiGN1fefKp3waTSX80hNDzNjXxowQ@mail.gmail.com>
References: <CAGa2bXY-cZ1teS9F64rzYhiGN1fefKp3waTSX80hNDzNjXxowQ@mail.gmail.com>
Date: Thu, 14 May 2015 10:55:43 +0200
Message-ID: <CAF+90c_59dtqFrQevtEw1TwZqQBNyq3nR3MUBYmYbGAy8QCVoA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae9cc9f96875ca2051606e414
Subject: Re: [PHP-DEV] mt_rand() behavior change is not in UPGRADING
From: nikita.ppv@gmail.com (Nikita Popov)

--14dae9cc9f96875ca2051606e414
Content-Type: text/plain; charset=UTF-8

On Thu, May 14, 2015 at 10:13 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> It's nice to see mt_rand() behavior is improved.
>
> [yohgaki@dev ~]$ php-5.6 -r "var_dump(mt_rand(222,
> '99999999999999999999999'));"
> int(115282844144104926)
> [yohgaki@dev ~]$ php-7.0 -r "var_dump(mt_rand(222,
> '99999999999999999999999'));"
>
> Warning: mt_rand() expects parameter 2 to be integer, string given in
> Command line code on line 1
> NULL
>
> However, returning NULL for invalid range may result in serious issues.
> It's not documented in UPGRADING.
>
> Could anyone responsible take care of it?
> I suppose mt_srand() behavior has changed also.
> There may be others.
>

This change is not mt_rand specific, it applies to all internal functions.
See https://wiki.php.net/rfc/zpp_fail_on_overflow. You are right that it is
not mentioned in UPGRADING yet.

Nikita

--14dae9cc9f96875ca2051606e414--