Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86143
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.178 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAFMT4Nop=1OSk9ruL679JacQURDf28hmcNFxXK5UWRFrg-_8gw@mail.gmail.com>
References: <CAMUwpuRJVmWwAMMdzAeoec=tvgkW1L++jxhDKjKbWvQNh5C7JQ@mail.gmail.com>
	<CAF+90c_HUkUQes2vt9x07+d7JMpt99DtEo9b9pRD_YQj6vF6TA@mail.gmail.com>
	<FCDF6A43-3935-4F1D-AC31-41BE47F4BAD2@ajf.me>
	<alpine.DEB.2.11.1407281459350.3793@whisky.home.derickrethans.nl>
	<71A78449-A62C-400D-A01F-5668930A7BED@ajf.me>
	<CA+9eiLvhPzb5OykP1HQAk-uWVZeKE4FYra_+AwdvM1FiEsJWvw@mail.gmail.com>
	<CAEZPtU43380x58xUwPVnChru--JNe=jE_eZE9sM801JmeJjFNA@mail.gmail.com>
	<CAF+90c9U1LohZ=iruh1M+F9cxAcM4X_VEqDkai97=qiXtF2rkg@mail.gmail.com>
	<554BDC4B.2010808@gmx.de>
	<CAEZPtU7=NZ=-8JLghT9TFvgU18FWbhyXMCTcYTmuBPVrRA4sLA@mail.gmail.com>
	<CAFMT4Nop=1OSk9ruL679JacQURDf28hmcNFxXK5UWRFrg-_8gw@mail.gmail.com>
Date: Fri, 8 May 2015 22:10:19 -0600
Message-ID: <CAFMT4NrO2CO-QMGUeB4uifV8n+5WqzB9ibXwKK=fh2vm3duZVQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Christoph Becker <cmbecker69@gmx.de>, Nikita Popov <nikita.ppv@gmail.com>, Andrea Faulds <ajf@ajf.me>, 
	Dmitry Stogov <dmitry@zend.com>, Julien Pauli <jpauli@php.net>, Derick Rethans <derick@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Thoughts on C version supported for PHP-Next
From: levim@php.net (Levi Morrison)

On Fri, May 8, 2015 at 7:13 AM, Levi Morrison <levim@php.net> wrote:
> On Fri, May 8, 2015 at 5:01 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>> On May 8, 2015 4:42 AM, "Christoph Becker" <cmbecker69@gmx.de> wrote:
>>>
>>> Nikita Popov wrote:
>>>
>>> > [...] What's our current minimum required vc version?
>>>
>>> As of PHP 5.5 at least VC11 (Visual Studio 2012) is required for Windows
>>> builds.  The currently available snapshots of master are also built with
>>> VC11[1].
>>
>> We are in the process of testing latest or better said the upcoming next
>> version of VC.
>>
>> However it is a long process. We use a couple of libs to test c99 support.
>>
>> What could be amazingly helpful, not only for VC, is some sample codes
>> using what we are most likely to use intensively from c99. It will allow is
>> to valid them against various compilers as well as clearly define what we
>> can support in the CS, all compilers we are likely to support for 7,
>> including VC, ICC or older GCC.
>>
>> Cheers,
>
> I am quite sure we would use these features:
>
>   - compound literals (this would allow for zend_string* at compile time)
>   - designated initializers
>
> I'll work on some code examples later today if someone hasn't beaten
> me to it by then.

Here is a self-contained example of designated initializers:

struct Point {
    int x;
    int y;
};

int main(void) {
    struct Point p = {
        .y = 2,
        .x = 1,
    };
    return !(p.x == 1 && p.y == 2);
}

And here is compound literals:

#include <stddef.h>

struct sstring {
    size_t len;
    char *val;
};

static struct sstring str;

int main(void) {
    str = (struct sstring) {
        sizeof("hello, world") - 1,
        "hello, world"
    };
    return !(str.len == sizeof("hello, world") - 1);
}


I expect in some cases we may even use them together. This particular
example doesn't really show why, but sometimes we have two uint32_t's
in a row and initializing them with a name helps make the code more
understandable:

#include <stddef.h>

struct sstring {
    size_t len;
    char *val;
};

static struct sstring str;

int main(void) {
    str = (struct sstring) {
        .len = sizeof("hello, world") - 1,
        .val = "hello, world",
    };
    return !(str.len == sizeof("hello, world") - 1);
}