Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86141
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain irker.net from 74.125.82.46 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAHvhOfh-O3iD+C=KR0aaEmGKrm-ZNQie++pZSDD8rj9WHjqPaA@mail.gmail.com>
References: <CAHvhOfh-O3iD+C=KR0aaEmGKrm-ZNQie++pZSDD8rj9WHjqPaA@mail.gmail.com>
Date: Fri, 8 May 2015 23:08:22 +0300
Message-ID: <CAMNmxHE5td=7ZozqmxW76h_TR8awDz=zBAvPD1rULvy=hKqLRg@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b5d34fa4bb6d70515979833
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: irker@irker.net (Alexander Moskalev)

--047d7b5d34fa4bb6d70515979833
Content-Type: text/plain; charset=UTF-8

Hi!

I try rewrite feature to use exists class:
https://github.com/php/php-src/commit/6319f954ca0674c77bb1f8f8409c9ac841fe301d

Please, take a look at this commit.

1) constructor does not require params
2) added curl_buffer_file_create function (like curl_file_create)
3) setters changed to allow binary data. May be it isn't good idea, but all
properties already have public access, so we can already set bad values. So
it just make common behavior for setters and manual setting properties.
4) If file name cast to true and contain a string - we use it.
5) If it still cast to true, but contain not a string - we report error
6) If file name cast to false - we use buffer

Please, check my commit and later I will create new pull request.

Thank you!




-- 
With regards, Alexander Moskalev
irker@irker.net
irker@php.net
a.moskalev@corp.badoo.com

--047d7b5d34fa4bb6d70515979833--