Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86108
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
Message-ID: <55479144.7060704@gmail.com>
Date: Mon, 04 May 2015 17:33:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: internals@lists.php.net
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Adding weekdays to DateTime resets the time
From: markus.fasselt@gmail.com (Markus Fasselt)

Hi,

when I modify a DateTime object and add or subtract weekdays, it happens
that the current time is reset to 00:00:00.

This effect does not occur when I add days. I also experienced the same
behavior with strototime.

> <?php
>
> $a = new DateTime(strtotime('2015-05-04 17:22'));
> var_dump((string) $a->format('Y-m-d H:i:s')); // 2015-05-04 17:22:00
> $a->modify('+1 day');
> var_dump((string) $a->format('Y-m-d H:i:s')); // 2015-05-05 17:22:00
> $a->modify('+1 weekday');
> var_dump((string) $a->format('Y-m-d H:i:s')); 2015-05-06 00:00:00
>
> var_dump(date('Y-m-d H:i:s', strtotime('+1 weekday'))); // 2015-05-05
00:00:00

http://3v4l.org/554H4

There seems to be slighly different behavior between the different PHP
versions. strotime always had this behavior. DateTime::modify() worked
correct until PHP 5.3.5.

I don't know if this behavior was changed on purpose (I didn't find
something on it). If so, why? Otherwise I would suggest to fix this, as
it is really confusing.

Regards,
Markus