Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86034
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
Sender: thegreatall@gmail.com
In-Reply-To: <CAGa2bXZGhWkBkVFFLJ6XCmMkj_G3Y89sX0Ay30D2R2i8ZXmdzQ@mail.gmail.com>
References: <CAGa2bXYzp3XimLXxC+Py2t1DWhCfX8coTdYHzf6zEiKdxA7r8Q@mail.gmail.com>
	<55401F31.9030703@gmail.com>
	<CAObuZduZBM0GyWJMA1Fd7eCgPE4vFFZrrhpREQ50a4QJhG6Nvg@mail.gmail.com>
	<CAGa2bXar_oXrsPAErNx5BUdkFAy-p8-D0tfhc3pAnDTGBGJJ7Q@mail.gmail.com>
	<55414CC5.7000503@gmx.de>
	<CAGa2bXZGhWkBkVFFLJ6XCmMkj_G3Y89sX0Ay30D2R2i8ZXmdzQ@mail.gmail.com>
Date: Wed, 29 Apr 2015 14:41:09 -0700
Message-ID: <CAMVzVHOJaMGst7fY=BG_jExMJaT=f-_80DCCXS8POx+wmR7w+Q@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Christoph Becker <cmbecker69@gmx.de>, Ryan Pallas <derokorian@gmail.com>, 
	Stanislav Malyshev <smalyshev@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113d162c5a8aff0514e3d6a4
Subject: Re: [PHP-DEV] Adding "numeric" type hint
From: nathanbruer@gmail.com (Nathan Bruer)

--001a113d162c5a8aff0514e3d6a4
Content-Type: text/plain; charset=UTF-8

This has been a big issue that I have ran into many times in the past for
large framework projects, instead of building it out with "strict" types
like: int, float, string, exc... It makes more sense to allow a user to
define a psudo-type themselves which PHP will pass the arguments into to be
"cleaned" by the user then let the function deal with the arguments.

For example:
function force_int($value){
  return (int) $value;
}
function must_be_string($v){
  if(!is_string($v)){
    throw new Exception("Not String");
  }
  return (string) $v;
}

function foo(*force_int $val, *must_be_string $str){
  // $val will always be an int if it ever gets here
  // $str will always be a string if it gets here
  echo $val, " ", $str;
}
foo("foo", "bar"); // returns '0 bar'
foo("1", "2"); // returns '1 2'
foo(1, 2); // fatal error because second argument threw exception
foo(1, "2") // returns '1 2'
foo("hi", 2) // fatal error because second argument threw exception
foo("hi", "2") // returns '0 2';

On Wed, Apr 29, 2015 at 2:39 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Christoph,
>
> On Thu, Apr 30, 2015 at 6:27 AM, Christoph Becker <cmbecker69@gmx.de>
> wrote:
>
> > > On Wed, Apr 29, 2015 at 9:33 AM, Ryan Pallas <derokorian@gmail.com>
> > wrote:
> > >
> > >> I agree with Stanislav here, if you want to accept any type of number,
> > its
> > >> easy enough to add your own checking to do that with the wonderful
> > >> is_numeric. And for simplicity, make an invalidArgument method that
> you
> > can
> > >> call after manually checking if arguments are wrong: *
> > http://3v4l.org/r0qO0
> > >> <http://3v4l.org/r0qO0>* Works for all versions this tool runs as
> well.
> > >
> > > The issue is that weak mode type hint is *not* weak at all. It forces
> to
> > > have
> > > machine native type rather than it's data form.
> >
> > A solution for this issue has been proposed by the "Big Integer Support"
> > RFC which has been withdrawn.  It's too late for PHP 7.0 to re-open it,
> > but it might be reasonable to to so for PHP 7.1.
>
>
> I don't think breaking a lot of code under 32 bit machines with PHP 7.0
> is not good thing to do.
>
> In addition, current code does not even allow GMP object as "int".
> http://3v4l.org/GiklL
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--001a113d162c5a8aff0514e3d6a4--