Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85966
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJW__o20G8e56Zdq9ZM1PwiKYffkMr=PzXwSufX46SzPmhtJ3A@mail.gmail.com>
References: <CAJW__o20G8e56Zdq9ZM1PwiKYffkMr=PzXwSufX46SzPmhtJ3A@mail.gmail.com>
Date: Mon, 27 Apr 2015 12:57:48 +0200
Message-ID: <CAF+90c8i9Boibrnes36O6QSz5XY0SYUxRJ5GPp0X55Bt9YomOw@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae9cc9f96dfa25c0514b29d33
Subject: Re: [PHP-DEV] Tweaks to memory_get_usage() and memory_get_peak_usage()
From: nikita.ppv@gmail.com (Nikita Popov)

--14dae9cc9f96dfa25c0514b29d33
Content-Type: text/plain; charset=UTF-8

On Mon, Apr 27, 2015 at 9:26 AM, Kalle Sommer Nielsen <kalle@php.net> wrote:

> Howdy
>
> After working with a couple of projects, I found it a little annoying
> that I would have to call memory_get_usage() twice first for
> emalloc()'d memory and after again for real memory, so I made a small
> patch that allows retrieving both values in a single call[1].
>
> The patch itself is rather simple, and does the same thing to
> memory_get_peak_usage(). It defines 3 constants: MEMORY_BOTH,
> MEMORY_EMALLOC & MEMORY_REAL. These allows code written prior this
> patch (if merged) to be compatible.
>
>
> Any objections for 7?
>
>
> [1] http://pastie.org/10115733
>

So basically this replaces

    $data = ['emalloc' => memory_get_usage(), 'real' =>
memory_get_usage(true)];

with

    $data = memory_get_usage(MEMORY_BOTH);

I don't think this change is really worthwhile...

Nikita

--14dae9cc9f96dfa25c0514b29d33--