Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85952
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.169 as permitted sender)
MIME-Version: 1.0
Date: Sun, 26 Apr 2015 17:33:15 +0200
Message-ID: <CAHvhOfh-O3iD+C=KR0aaEmGKrm-ZNQie++pZSDD8rj9WHjqPaA@mail.gmail.com>
To: Alexander Moskalev <irker@irker.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e015366e04a37c30514a25ab9
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: kelerest123@gmail.com (=?UTF-8?B?SmFrdWIgS3Viw63EjWVr?=)

--089e015366e04a37c30514a25ab9
Content-Type: text/plain; charset=UTF-8

Hey Alexander!

2015-04-22 10:26 GMT+02:00 Alexander Moskalev <irker@irker.net>:

> Jakub, I think about static factory methods, but not sure if it will be
> great.
>  I think using empty constructor more clear.
>

So we can add a setter, which, however, will return $this, to allow
chaining and prevent one redundant line of code:

<?php

$fileBuffer = (new CURLFile)->setBuffer('some file contents');
// ($fileBuffer instanceof CURLFile) === true

But this looks a bit weird and for some people also confusing. Thus it
would be even better to have a static factory method, I think.


Best regards,
Kubo2

--089e015366e04a37c30514a25ab9--