Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:85942 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42850 invoked from network); 24 Apr 2015 08:47:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Apr 2015 08:47:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=irker@irker.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=irker@irker.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain irker.net from 74.125.82.41 cause and error) X-PHP-List-Original-Sender: irker@irker.net X-Host-Fingerprint: 74.125.82.41 mail-wg0-f41.google.com Received: from [74.125.82.41] ([74.125.82.41:32931] helo=mail-wg0-f41.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E9/B0-36715-D330A355 for ; Fri, 24 Apr 2015 04:47:58 -0400 Received: by wgin8 with SMTP id n8so43319378wgi.0 for ; Fri, 24 Apr 2015 01:47:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=0hBz95lNBm8JAqpKAwC3f9LrLOi45musXSSIirJ/Aik=; b=BeVulLqvbDTS4tMx123pykmuBdw5BBpinSwX2YigB4SydXBLkG5HiWDapjvJKjIRMJ w6Ev8OCo7mnCV+dym6bPFemje1MAmbrhqgKQAiTn+flDM9aAtP9M8rUCg2uCbX98uO1W HFqSEEflxUZeSU5QtI2I0Um4cuQ4YCny5yqNbEBskuxpeTjmjGerZWElV0OT6jBkNzj+ /yyCyWSZ6g6XabPw486Fm25YpS97+6jmAVa7UBmTZMvxHtlZ5pht6AcrgrrUyCeELv+i AvGZWPNPwSxHYHGmq6giqCInB2zmAx9xJ3N6SNzhQ+mBX+lFmJRBmKfiER2DXAjz/UAb TdrQ== X-Gm-Message-State: ALoCoQkih6bB1msGQn2zTgu0rqkt7e2nESOv6B9wFQVaO80keVbdMUCRZvfoBn5bskYiQP8kFpkg X-Received: by 10.194.206.66 with SMTP id lm2mr13448843wjc.79.1429865275184; Fri, 24 Apr 2015 01:47:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.91.66 with HTTP; Fri, 24 Apr 2015 01:47:34 -0700 (PDT) In-Reply-To: References: <5532CE2E.1040607@gmail.com> <66000802-0F7E-4071-A8F7-A1E80F4DD1CC@gmail.com> Date: Fri, 24 Apr 2015 11:47:34 +0300 Message-ID: To: Alexey Zakhlestin Cc: Michael Wallner , PHP Internals , =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= , Stanislav Malyshev Content-Type: multipart/alternative; boundary=047d7b873d52cdf316051474732d Subject: Re: PR 1217: Add support for upload files from buffer string in curl extenion From: irker@irker.net (Alexander Moskalev) --047d7b873d52cdf316051474732d Content-Type: text/plain; charset=UTF-8 2015-04-24 11:10 GMT+03:00 Alexander Moskalev : > I think It same as my current pull-request - another class with duplicate > functionality and duplicate code. We save only few strings from base class > with $postname field. > What benefits we will add using inheriting from CURLFile for php > developers? > Sorry, was from mobile client. So if we will inherit from CURLFile, we can inherit setters and getters for post filename and mime type. It's OK. But also we will have inherited method "getFilename", that is not logical correct for buffer file. More correct to have another base class for both CURLFile and CURLFIleBuffer. But it so complicated for this small feature request. I think we must use one of simplest ways: new class as in my pull-request or integrate functionality to old class as described before in this thread. -- With regards, Alexander Moskalev irker@irker.net irker@php.net a.moskalev@corp.badoo.com --047d7b873d52cdf316051474732d--