Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:85939 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35211 invoked from network); 24 Apr 2015 08:11:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Apr 2015 08:11:01 -0000 Authentication-Results: pb1.pair.com smtp.mail=irker@irker.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=irker@irker.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain irker.net from 74.125.82.54 cause and error) X-PHP-List-Original-Sender: irker@irker.net X-Host-Fingerprint: 74.125.82.54 mail-wg0-f54.google.com Received: from [74.125.82.54] ([74.125.82.54:34798] helo=mail-wg0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 35/02-19336-49AF9355 for ; Fri, 24 Apr 2015 04:11:00 -0400 Received: by wgso17 with SMTP id o17so42456296wgs.1 for ; Fri, 24 Apr 2015 01:10:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=VbnoWq4S4VkQ9+sa5LvOKh+0EA5VvHAKNmahzdybq3M=; b=giyfueWkKqiQ7GT/LH+Bf577myrOP5moxDScHnh9wIfKRawGXAlHAjc4fIlktJDkHr XTjQ2WrM6ZOKSWjx7ZnFfR1LoAorXW5IT5Qq/ssbOTFwv4eaPANWDxEBC10Sbo4LEwrO TV09Rsl4gvo+Th23FKQKmu3xG+1cZQyEhz4gx1XENjf2m9YS/JbVFjMF/QSFQO6jtzTF 4rYX8+hrXDV+HmTkzkABREb69XJmnII7bb40VEfQtaS2QG6EjicnfU2HAM0TgAmzRJje sOF/WnwLCT/Dl1aRnF2pR2ETkez9hwWto7SJ8dNqigwbbzd2OCTTerKTOm0zq4nR9q8G TPPw== X-Gm-Message-State: ALoCoQmtdhon7IuSQLRPnB+LOaPf1YpoiaDuGhgtcstom0u7a4n0e9BpRuv0UKey7yVrT5LNK5Fh MIME-Version: 1.0 X-Received: by 10.180.104.4 with SMTP id ga4mr1587032wib.86.1429863057305; Fri, 24 Apr 2015 01:10:57 -0700 (PDT) Received: by 10.28.56.4 with HTTP; Fri, 24 Apr 2015 01:10:57 -0700 (PDT) In-Reply-To: <66000802-0F7E-4071-A8F7-A1E80F4DD1CC@gmail.com> References: <5532CE2E.1040607@gmail.com> <66000802-0F7E-4071-A8F7-A1E80F4DD1CC@gmail.com> Date: Fri, 24 Apr 2015 11:10:57 +0300 Message-ID: To: Alexey Zakhlestin Cc: Michael Wallner , PHP Internals , =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= , Stanislav Malyshev Content-Type: multipart/alternative; boundary=f46d044271829bcbd7051473ef10 Subject: Re: PR 1217: Add support for upload files from buffer string in curl extenion From: irker@irker.net (Alexander Moskalev) --f46d044271829bcbd7051473ef10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I think It same as my current pull-request - another class with duplicate functionality and duplicate code. We save only few strings from base class with $postname field. What benefits we will add using inheriting from CURLFile for php developers? =D0=BF=D1=8F=D1=82=D0=BD=D0=B8=D1=86=D0=B0, 24 =D0=B0=D0=BF=D1=80=D0=B5=D0= =BB=D1=8F 2015 =D0=B3. =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1= =82=D0=B5=D0=BB=D1=8C Alexey Zakhlestin =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB: > > > On 23 Apr 2015, at 14:26, Alexander Moskalev > wrote: > > > > Because currently CURLFile have this constructor: > > public __construct ( > > string $filename [, string $mimetype [, string $postname ]] ) > > > > And we cannot replace this arguments to avoid BC break. > > (Do not top-post please.) > > Well=E2=80=A6 We can introduce another class, which would inherit from CU= RLFile. > Similar to how SplTempFileObject extends SplFileObject. > > > > =D0=90. > > --=20 With regards, Alexander Moskalev irker@irker.net irker@php.net a.moskalev@corp.badoo.com --f46d044271829bcbd7051473ef10--