Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain irker.net from 209.85.212.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <CALJZF3hDEMzAMDDtPXMpf6Y5TLi_9tUNh5gJoOmoG_iFvwyqkg@mail.gmail.com>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
 <5532CE2E.1040607@gmail.com> <CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com>
 <CAMNmxHF1RUUwF+bZZB2eJfu_11Srj09YBCmG58hLX-2VWLtnCQ@mail.gmail.com> <CALJZF3hDEMzAMDDtPXMpf6Y5TLi_9tUNh5gJoOmoG_iFvwyqkg@mail.gmail.com>
Date: Thu, 23 Apr 2015 14:26:01 +0300
Message-ID: <CAMNmxHEr4zxphUiqwO9euOeH6jH8FTSkrOyWGUCFtLgJpt0aYg@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: PHP Internals <internals@lists.php.net>, =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= <kelerest123@gmail.com>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=047d7ba97780a591580514628cbd
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: irker@irker.net (Alexander Moskalev)

--047d7ba97780a591580514628cbd
Content-Type: text/plain; charset=UTF-8

Because currently CURLFile have this constructor:
public __construct <http://php.net/manual/en/curlfile.construct.php> (
string $filename [, string $mimetype [, string $postname ]] )

And we cannot replace this arguments to avoid BC break.

2015-04-23 11:59 GMT+03:00 Michael Wallner <mike@php.net>:

>
> On 22 Apr 2015 10:27, "Alexander Moskalev" <irker@irker.net> wrote:
> >
> > Thanks to all for feedback!
> >
> > Let's try to integrate new feature to old class.
> > We have constructor in CURLFile with one required parameter: $filename .
> > To avoid BC break we cannot replace this parameter. So  I suggest to do
> it
> > optional and add setBuffer() method.
> >
> > So we can create CURLFile with empty parameters in constructor and fill
> it
> > with setters.
> > Have two more questions:
> > 1) If we not fill all options or fille not compatible options, when we
> must
> > throw error? ? And what level of this error? (Sorry, I'm just php coder
> and
> > know about C language and php source so little)
> > For file from disk(or other source) required $filename. For file from
> > buffer required $buffer and $postname.
> > 2) Curently CURLFile cannot be unserialized, because it contains
> $filename
> > (see source code). How it compatible with our dicussion?
> >
>
> Why not a ctor as in:
>
> function __construct ($filename, $buffer = null) {
>     if (isset ($ buffer)) {
>         // use $ buffer
>     } else {
>         // use file contents
>     }
> }
>
> The file name parameter can be of use anyway for posted file contents from
> buffer.
>
> Cheers,
> Mike
>



-- 
With regards, Alexander Moskalev
irker@irker.net
irker@php.net
a.moskalev@corp.badoo.com

--047d7ba97780a591580514628cbd--