Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85913
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.169 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
In-Reply-To: <CALJZF3hDEMzAMDDtPXMpf6Y5TLi_9tUNh5gJoOmoG_iFvwyqkg@mail.gmail.com>
Date: Thu, 23 Apr 2015 12:37:01 +0300
Cc: Alexander Moskalev <irker@irker.net>,
 PHP Internals <internals@lists.php.net>,
 =?utf-8?Q?Jakub_Kub=C3=AD=C4=8Dek?= <kelerest123@gmail.com>,
 Stanislav Malyshev <smalyshev@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-ID: <CBF5BA8E-0405-4045-A712-D3059B6730BA@gmail.com>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com> <5532CE2E.1040607@gmail.com> <CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com> <CAMNmxHF1RUUwF+bZZB2eJfu_11Srj09YBCmG58hLX-2VWLtnCQ@mail.gmail.com> <CALJZF3hDEMzAMDDtPXMpf6Y5TLi_9tUNh5gJoOmoG_iFvwyqkg@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer string in curl extenion
From: indeyets@gmail.com (Alexey Zakhlestin)


> On 23 Apr 2015, at 11:59, Michael Wallner <mike@php.net> wrote:
>=20
> Why not a ctor as in:
>=20
> function __construct ($filename, $buffer =3D null) {
>    if (isset ($ buffer)) {
>        // use $ buffer
>    } else {
>        // use file contents
>    }
> }
>=20
> The file name parameter can be of use anyway for posted file contents =
from
> buffer.

Looks good! So, it work like this (+ error handling)

function __construct($filename, $buffer =3D null)
{
    $this->filename =3D $filename;

    if (is_null($buffer)) {
        $this->data =3D file_get_contents($filename);
    } else {
        $this->data =3D buffer;
    }
}



=D0=90.