Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85912
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.48 as permitted sender)
MIME-Version: 1.0
Sender: mike.php.net@gmail.com
In-Reply-To: <CAMNmxHF1RUUwF+bZZB2eJfu_11Srj09YBCmG58hLX-2VWLtnCQ@mail.gmail.com>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
	<5532CE2E.1040607@gmail.com>
	<CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com>
	<CAMNmxHF1RUUwF+bZZB2eJfu_11Srj09YBCmG58hLX-2VWLtnCQ@mail.gmail.com>
Date: Thu, 23 Apr 2015 10:59:33 +0200
Message-ID: <CALJZF3hDEMzAMDDtPXMpf6Y5TLi_9tUNh5gJoOmoG_iFvwyqkg@mail.gmail.com>
To: Alexander Moskalev <irker@irker.net>
Cc: PHP Internals <internals@lists.php.net>, =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= <kelerest123@gmail.com>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c3ca3a9c493f0514607f84
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: mike@php.net (Michael Wallner)

--001a11c3ca3a9c493f0514607f84
Content-Type: text/plain; charset=UTF-8

On 22 Apr 2015 10:27, "Alexander Moskalev" <irker@irker.net> wrote:
>
> Thanks to all for feedback!
>
> Let's try to integrate new feature to old class.
> We have constructor in CURLFile with one required parameter: $filename .
> To avoid BC break we cannot replace this parameter. So  I suggest to do it
> optional and add setBuffer() method.
>
> So we can create CURLFile with empty parameters in constructor and fill it
> with setters.
> Have two more questions:
> 1) If we not fill all options or fille not compatible options, when we
must
> throw error? ? And what level of this error? (Sorry, I'm just php coder
and
> know about C language and php source so little)
> For file from disk(or other source) required $filename. For file from
> buffer required $buffer and $postname.
> 2) Curently CURLFile cannot be unserialized, because it contains $filename
> (see source code). How it compatible with our dicussion?
>

Why not a ctor as in:

function __construct ($filename, $buffer = null) {
    if (isset ($ buffer)) {
        // use $ buffer
    } else {
        // use file contents
    }
}

The file name parameter can be of use anyway for posted file contents from
buffer.

Cheers,
Mike

--001a11c3ca3a9c493f0514607f84--