Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85882
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain irker.net from 74.125.82.46 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
 <5532CE2E.1040607@gmail.com> <CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com>
Date: Wed, 22 Apr 2015 11:26:20 +0300
Message-ID: <CAMNmxHF1RUUwF+bZZB2eJfu_11Srj09YBCmG58hLX-2VWLtnCQ@mail.gmail.com>
To: =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= <kelerest123@gmail.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04138cd528b92c05144bece7
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: irker@irker.net (Alexander Moskalev)

--f46d04138cd528b92c05144bece7
Content-Type: text/plain; charset=UTF-8

Thanks to all for feedback!

Let's try to integrate new feature to old class.
We have constructor in CURLFile with one required parameter: $filename .
To avoid BC break we cannot replace this parameter. So  I suggest to do it
optional and add setBuffer() method.

So we can create CURLFile with empty parameters in constructor and fill it
with setters.
Have two more questions:
1) If we not fill all options or fille not compatible options, when we must
throw error? ? And what level of this error? (Sorry, I'm just php coder and
know about C language and php source so little)
For file from disk(or other source) required $filename. For file from
buffer required $buffer and $postname.
2) Curently CURLFile cannot be unserialized, because it contains $filename
(see source code). How it compatible with our dicussion?


Jakub, I think about static factory methods, but not sure if it will be
great.
 I think using empty constructor more clear.

--f46d04138cd528b92c05144bece7--