Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85870
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5532CE2E.1040607@gmail.com>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
 <5532CE2E.1040607@gmail.com>
Date: Sun, 19 Apr 2015 17:41:08 +0200
Message-ID: <CAHvhOfhDd0OxshBeo52RS1mZvV0PpzuqCi0ndRL3fzt8dbB9EA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Alexander Moskalev <irker@irker.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134f14c9ae3b6051415a5b2
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer
 string in curl extenion
From: kelerest123@gmail.com (=?UTF-8?B?SmFrdWIgS3Viw63EjWVr?=)

--001a1134f14c9ae3b6051415a5b2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

So, get directly to your questions:

>
> 1) Can we still integrate this functionality to existing class CURLFile?


I think it would be possible, because like @smalyshev said, CURLFile
represents symbolic file, that is going to be uploaded with CURL. So my
suggestion would be creating a static factory method on this class,
something like `CURLFile::createFromBuffer( string )` or
`CURLFile::loadFromBuffer( string )`, which would create a CURLFile object
and initialize it with the passed contents (=E2=80=9Ebuffer=E2=80=9C).

3) What do you think about unserialization for this class?
> a) Do not accept it (becouse object can contain very big file)
> b) Accept


I am for (un)serialization for this class. I think it's upon its user to
think whether to use it or not (because it could be a benefit, but there
are also situations, when it's not -- like that case, in which you have
very large file buffer).


Best reagards,
Kubo2


2015-04-18 23:35 GMT+02:00 Stanislav Malyshev <smalyshev@gmail.com>:

> Hi!
>
> > I have few questions for my pull request:
> > https://github.com/php/php-src/pull/1217
> >
> > Short story: in some special cases we need to upload just created small
> > file(s) by CURL. For example it's autogenerated image or pdf. And libcu=
rl
> > give for us this options: CURLFORM_BUFFER, CURLFORM_BUFFERPTR and
> > CURLFORM_BUFFERLENGTH. My request about adding this options to curl php
> > extension.
>
> I wonder if it's be hard to make streams work there... Then you could
> just pass php://memory or data:// as the file. Not sure about security
> implications though, needs some thinking.
>
> > For basement I used class CURLFile, but can't find solution to use same
> > class, because this class require file name on disc parameter in
> > constructor. So I created new class, now it called as CURLBufferFile.
>
> While it does require file name as parameter, nobody says anything about
> disc there. So in addition to the above, you just could add
> setFileContents() API (or setFileBuffer? feel free to bikeshed :) that
> would make it take existing buffer instead of reading the file.
>
> > So, my questions are:
> > 1) Can we still integrate this functionality to exists class CURLFile?
>
> I think, yes. Or at least we should try to. The meaning of CURLFile is
> not "file on disk", it's "something to be fed to CURL to be uploaded as
> a file", so having buffer does not violate the semantics.
>
> > 3) What do you think about unserialization for this class?
> > a) Do not accept it (becouse object can contain very big file)
> > b) Accept
>
> I don't see big issue in serializing/unserializing it. Yes, it can be
> big. So can be any string you can pass to unserializer, any object can
> contain tons of data, nothing different here. This object is just
> container for its values, so I don't see anything special here.
> --
> Stas Malyshev
> smalyshev@gmail.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a1134f14c9ae3b6051415a5b2--