Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85866
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.43 as permitted sender)
Message-ID: <5532CE2E.1040607@gmail.com>
Date: Sat, 18 Apr 2015 14:35:42 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Alexander Moskalev <irker@irker.net>, 
 "internals@lists.php.net" <internals@lists.php.net>
References: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
In-Reply-To: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PR 1217: Add support for upload files from buffer string
 in curl extenion
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I have few questions for my pull request:
> https://github.com/php/php-src/pull/1217
> 
> Short story: in some special cases we need to upload just created small
> file(s) by CURL. For example it's autogenerated image or pdf. And libcurl
> give for us this options: CURLFORM_BUFFER, CURLFORM_BUFFERPTR and
> CURLFORM_BUFFERLENGTH. My request about adding this options to curl php
> extension.

I wonder if it's be hard to make streams work there... Then you could
just pass php://memory or data:// as the file. Not sure about security
implications though, needs some thinking.

> For basement I used class CURLFile, but can't find solution to use same
> class, because this class require file name on disc parameter in
> constructor. So I created new class, now it called as CURLBufferFile.

While it does require file name as parameter, nobody says anything about
disc there. So in addition to the above, you just could add
setFileContents() API (or setFileBuffer? feel free to bikeshed :) that
would make it take existing buffer instead of reading the file.

> So, my questions are:
> 1) Can we still integrate this functionality to exists class CURLFile?

I think, yes. Or at least we should try to. The meaning of CURLFile is
not "file on disk", it's "something to be fed to CURL to be uploaded as
a file", so having buffer does not violate the semantics.

> 3) What do you think about unserialization for this class?
> a) Do not accept it (becouse object can contain very big file)
> b) Accept

I don't see big issue in serializing/unserializing it. Yes, it can be
big. So can be any string you can pass to unserializer, any object can
contain tons of data, nothing different here. This object is just
container for its values, so I don't see anything special here.
-- 
Stas Malyshev
smalyshev@gmail.com