Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85859
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain irker.net from 209.85.212.182 cause and error)
MIME-Version: 1.0
Date: Sat, 18 Apr 2015 13:46:18 +0300
Message-ID: <CAMNmxHGc4yX4TqPqSs1Oue7S5Y8h7CQF0Z7C_X-ydSdstJz2iw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b3a896c5c6ff70513fd69b4
Subject: PR 1217: Add support for upload files from buffer string in curl extenion
From: irker@irker.net (Alexander Moskalev)

--047d7b3a896c5c6ff70513fd69b4
Content-Type: text/plain; charset=UTF-8

Hi all!

I have few questions for my pull request:
https://github.com/php/php-src/pull/1217

Short story: in some special cases we need to upload just created small
file(s) by CURL. For example it's autogenerated image or pdf. And libcurl
give for us this options: CURLFORM_BUFFER, CURLFORM_BUFFERPTR and
CURLFORM_BUFFERLENGTH. My request about adding this options to curl php
extension.

For basement I used class CURLFile, but can't find solution to use same
class, because this class require file name on disc parameter in
constructor. So I created new class, now it called as CURLBufferFile.

So, my questions are:
1) Can we still integrate this functionality to exists class CURLFile?

2) If no, what do you think about class name?
a) CURLBufferFile
b) CURLBuffer
c) CURLFileBuffer
d) ... other

3) What do you think about unserialization for this class?
a) Do not accept it (becouse object can contain very big file)
b) Accept

Thanks!

-- 
With regards, Alexander Moskalev
irker@irker.net
irker@php.net
a.moskalev@corp.badoo.com

--047d7b3a896c5c6ff70513fd69b4--