Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85796
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.177 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
In-Reply-To: <CAEKnhAHjM2RY+Z2iB7D5wAb=FA43vMkKb1+34O-rTsuV222YUg@mail.gmail.com>
Date: Tue, 14 Apr 2015 07:31:17 +0300
Cc: PHP internals list <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <C2187224-4574-4E56-BFF5-CCE2E01E6968@gmail.com>
References: <CAEKnhAHjM2RY+Z2iB7D5wAb=FA43vMkKb1+34O-rTsuV222YUg@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Subject: Re: [PHP-DEV] JSON float number as string
From: indeyets@gmail.com (Alexey Zakhlestin)


> On 29 Mar 2015, at 22:33, Jakub Zelenka <bukka@php.net> wrote:
>=20
> I would like to add a new option to JSON for dealing with large =
floats. The
> use case is mainly for decoder but can be used for encoder as well.
>=20
> JSON_FLOAT_AS_STRING
> decode: all float values will be decoded as string
> - It's often an issue for very large float values with many fractional
> digits that are coming from platforms that support larger float
> representation than double. In that case the conversion is lost and =
there
> is no way how to get it back (see http://bugs.php.net/68456 [pls =
ignore my
> initial dump comments when I didn't get the issue :)] and an example =
of the
> lost precision here http://3v4l.org/80iCh ). Converting the value to =
string
> keep the precision and resolves the problem.
>=20
> encode: all float values will be encoded as string
> - re-using the constant for encoder makes sense if PHP creates JSON =
for
> platform that support lower float type (e.g. C float) and the =
precision
> loss is not acceptable
>=20
>=20
> I think that this is more a bugfix as the precision is lost without =
any way
> how to get it back (except pre-processing json string with regular
> expression). I would like to add it to 5.6.x if there are no =
objections?

Feels a bit hackish
I think it is possible to introduce an overall better solution

We can expose result of json-tokenizing as a tree of objects:

JSON\Object
JSON\Array
JSON\String
JSON\Number
JSON\False
JSON\True
JSON\Null

then, it would be possible to introduce any number of experimental =
userland implementations like the one proposed here

--=20
Alexey Zakhlestin
https://github.com/indeyets
PGP key: http://indeyets.ru/alexey.zakhlestin.pgp.asc