Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85764
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsKMJCW+7EjuS7_DBDxAet2XpHWKmvzY2SdxcFFi_WO+Q@mail.gmail.com>
References: <CA+9eiLsKMJCW+7EjuS7_DBDxAet2XpHWKmvzY2SdxcFFi_WO+Q@mail.gmail.com>
Date: Fri, 10 Apr 2015 05:26:31 +0100
Message-ID: <CAKxcST9hJBiOz942vt2R-G0s9TOSJwam-XdXR7zmRF2rKam_hg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Xinchen Hui <xinchen.h@zend.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1132ff9c2ee3bc0513572bce
Subject: Re: [PHP-DEV] _call() and __callstatic() improvement
From: dragoonis@gmail.com (Paul Dragoonis)

--001a1132ff9c2ee3bc0513572bce
Content-Type: text/plain; charset=UTF-8

Hi Dmitry,

Although I recommend against the usage of __call/__callStatic from a
quality assurance perspective (part of my job), it's reassuring to know
that these methods have received more attention in terms of stability and
stack handling.

After reviewing the code I'd still like to better understand the use of the
term trampoline and when it's appropriate to
use zend_get_call_trampoline_func() over the
existing zend_get_user_call_function() approach.

Many thanks,
Paul

On Fri, Apr 10, 2015 at 12:20 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi,
>
> Please review the patch.
> It improves implementation of magic __call() and __callstatic() methods
> using bytecode function with trampoline instead of internal C function.
>
> https://github.com/php/php-src/pull/1234
>
> The patch is more or less obvious.
> I'm going to commit it tomorrow evening.
>
> Xinchen, you may also try to add support for Closure::invoke() (as a
> separate patch).
>
> Thanks. Dmitry.
>

--001a1132ff9c2ee3bc0513572bce--