Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85762
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c89oL54vo556WMtuZKPZu_5WkL1AHt=RFS__Kdwt1X4Rg@mail.gmail.com>
References: <CAF+90c89oL54vo556WMtuZKPZu_5WkL1AHt=RFS__Kdwt1X4Rg@mail.gmail.com>
Date: Fri, 10 Apr 2015 02:32:24 +0300
Message-ID: <CA+9eiLuZqc6czDWB9B-4UKuji9L3LOf+LfY8cnujmT6M0=TBHw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec51b9a515ff4b40513530fa8
Subject: Re: [PHP-DEV] Exception message cleanup
From: dmitry@zend.com (Dmitry Stogov)

--bcaec51b9a515ff4b40513530fa8
Content-Type: text/plain; charset=UTF-8

On Thu, Apr 9, 2015 at 11:04 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> A lot of people have been confused about engine exceptions currently
> displaying as normal fatal errors (if they aren't caught). We'll have to
> change this to use exception messages.
>
> Before doing this I'd like to clean up the messages a bit to make them more
> friendly for CLI usage. Currently the messages are so cluttered that it's
> hard to find the actual error message if you're in an 80 char window.
>
> Patch is here: https://github.com/php/php-src/pull/1226
>
> Previous message:
>
> Fatal error: Uncaught exception 'UnexpectedValueException' with message
> 'Failed to open directory ""' in %s:%d
> Stack trace:
> #0 %s(%d): DirectoryIterator->__construct('\x00/abc')
> #1 {main}
>   thrown in %s on line %d
>
> New message:
>
> UnexpectedValueException: Failed to open directory "" in %s on line %d
> Stack trace:
> #0 %s(%d): DirectoryIterator->__construct('\x00/abc')
> #1 {main}
>
> Essentially exceptions would display like ordinary error, but with "Fatal
> error" / "Warning" / ... replaced by the exception name, and showing a
> stack trace after the error.
>
> A side-effect of the change is that uncaught exceptions will always be
> displayed canonically and not based on __toString output. To modify display
> of exception output, people should modify the respective properties of the
> exception.
>
> Any objections to this?
>

We will have to change half of PHPT tests.
New tests with fatal errors are going to be incompatible between PHP-5 and
PHP-7.
Log analysers written for PHP-5  won't work with PHP-7.

Thanks. Dmitry.


>
> Thanks,
> Nikita
>

--bcaec51b9a515ff4b40513530fa8--