Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85758
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <004801d072cf$b4f69500$1ee3bf00$@php.net>
References: <CAAyV7nH6D3Ot6SBK6KkUbFao8S_KhdGYU=dWjmjc7BvLORL+1Q@mail.gmail.com>
	<CAN383GAxtqBcaSmCRoG9tqL79AcytszAfECf+Nn5SNAFawEEEQ@mail.gmail.com>
	<CAAyV7nELGjqZMr-sU1yFajxBTJPZeTdbb68re1Vf_KXtNUDEjw@mail.gmail.com>
	<004801d072cf$b4f69500$1ee3bf00$@php.net>
Date: Thu, 9 Apr 2015 11:16:55 -0400
Message-ID: <CAAyV7nFWCmbSNgofCuWdowpHozb94PciHs7FvVBD_n-jKTyG_w@mail.gmail.com>
To: francois@php.net
Cc: jpauli <julienpauli@gmail.com>, Andi Gutmans <andi@zend.com>, internals@lists.php.net, 
	Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=001a113478ec62e1fb05134c23e7
Subject: RE: [PHP-DEV] Concern around growing complexity in engine - hash
 table specifically
From: ircmaxell@gmail.com (Anthony Ferrara)

--001a113478ec62e1fb05134c23e7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Fancois,
On Apr 9, 2015 10:16 AM, "Fran=C3=A7ois Laupretre" <francois@php.net> wrote=
:
>
> > De : Anthony Ferrara [mailto:ircmaxell@gmail.com]
> >
> > If we were using a pure abstraction (only accessing the hash table
> > information through the public API), then fine because it's isolated.
> > However, many extensions and even places in core access hash table
> > structure directly (as can be seen by the updates needed by
> > https://github.com/php/php-
> > src/commit/2b42d719084631d255ec7ebb6c2928b9339915c2).
> > Meaning the complexity isn't encapsulated.
>
> IMHO, that's the main problem. If a piece of code is accessed through an
official published API only, its internal complexity can grow, provided the
API still provides the same services. So, the first step should be to
define and publish an 'official' full-featured API.

We already have one. The public API defined in zend_hash.h (all methods and
macros not prefixed with "_").

And my argument would be if code outside of zend_hash.(c|h) needs to access
the internal hash table structure for anything (a public API doesn't serve
the needs), then a new macro or API should be introduced for that use-case
(so that it doesn't need to access the structure anymore).

Anthony

--001a113478ec62e1fb05134c23e7--