Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85699
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.215.53 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAObuZduomooUsjsTrvH63HrFp4z7GsZQtBvptC3XzakPD=9-jg@mail.gmail.com>
References: <CA+kxMuSvxRq-AvjQSBUc-FiYdTrD_1X2SuQtjWRjTwAbcwWRoA@mail.gmail.com>
	<551CEDF6.7090408@lerdorf.com>
	<CAJhmKHkyJN8E7RGOo19bYVQ5JjPaJcW8iJ+ad4VPzGiGC54+uA@mail.gmail.com>
	<CA+kxMuR3NjCGf+Xz1w+NDR0hPAYS=LCDkJMG_p_ZNK4rZmJ7=Q@mail.gmail.com>
	<CADajX4DqVQP0rGbLzu1YVrcamyYWj0JqoiDryWPuenQCQtj6wg@mail.gmail.com>
	<CAObuZduomooUsjsTrvH63HrFp4z7GsZQtBvptC3XzakPD=9-jg@mail.gmail.com>
Date: Thu, 2 Apr 2015 21:13:40 +0000
Message-ID: <CA+kxMuSCLo2VnGnHngW7WEhSjGuEH=+DiLb=ngYVDYHhNQ2Zfg@mail.gmail.com>
To: Ryan Pallas <derokorian@gmail.com>
Cc: Adam Harvey <aharvey@php.net>, Keyur Govande <keyurgovande@gmail.com>, 
	Rasmus Lerdorf <rasmus@lerdorf.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Deprecate setlocale?
From: danack@basereality.com (Dan Ackroyd)

Adam Harvey wrote:
> What about just adding another function: setlocale_global(), or similar?

Do you mean setlocale would become the thread safe one, and
setlocale_global() would be the current behaviour? If so, that would
be a BC break for the small number of people who are deliberately
using setlocale globally. We could do that at a major version I guess.

I think the ini setting is still better - it allows people to use code
that was written assuming that setlocale was safe to use, rather than
forcing them to change it.

It might be best to introduce both setlocale_ts() and
setlocale_global(), so that users could call either explicitly, and
have the ini setting control which one setlocale() points to. If we
did that we could also then plan to eventually deprecate both the ini
setting and the plain setlocale without _ts/_global.

Ryan Pallas wrote:
> I like the idea of an INI actually, but I would make it default to the current behaviour and user education so those who need TS know to change it.

The problem with that is that for people who aren't aware of the
setting, they wouldn't know that they need to change the setting.
Instead they just want their code to work properly 'out of the box'.
For the vast majority of people calling the thread safe version of
setlocale would be what they problem want it to do, and so PHP should
default to the right thing for the majority of people.

Of course there is a separate argument about changing the behaviour at
major/minor version, and if this was introduced then having to
`thread_safe_setlocale=off` for 7.1 and `thread_safe_setlocale=on` for
8 could be correct.

cheers
Dan