Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85643
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <D3036E76-05FE-4B4A-91E2-BF6B3B079546@php.net>
References: <CA+kxMuSvxRq-AvjQSBUc-FiYdTrD_1X2SuQtjWRjTwAbcwWRoA@mail.gmail.com>
	<D3036E76-05FE-4B4A-91E2-BF6B3B079546@php.net>
Date: Wed, 1 Apr 2015 19:18:21 +0200
Message-ID: <CAH-PCH6d=DabLs5VPcE+depUDrTnCjOOgZ-gPNcdav-jRwvrvQ@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: Dan Ackroyd <danack@basereality.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b4724aced59bb0512ace6b9
Subject: Re: [PHP-DEV] Deprecate setlocale?
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7b4724aced59bb0512ace6b9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 1, 2015 at 7:08 PM, Michael Wallner <mike@php.net> wrote:

>
> > On 01 04 2015, at 18:15, Dan Ackroyd <danack@basereality.com> wrote:
> >
> > Hi,
> >
> > I'd like to get people's feedback for the idea of making setlocale be
> > either deprecated and to be removed eventually or just increasing the
> > warning level against people using it.
> >
> > The short version of why we should do this is that setlocale breaks
> > things. It is a process wide operation, that is not thread safe on
> > most platforms. Although people use it to alter the way strings are
> > output, it also breaks libraries that are assuming that they are
> > running in a "C" locale.
> >
> > https://bugs.php.net/bug.php?id=3D59571 - breaks Imagick
> > https://bugs.php.net/bug.php?id=3D54538 - breaks NumberFormatter
> > https://bugs.php.net/bug.php?id=3D66108 - breaks constants
> > https://bugs.php.net/bug.php?id=3D67127 - breaks DateTime
> > https://bugs.php.net/bug.php?id=3D69348 - breaks MySQL
> >
> > And there are quite a few other bug reports where setlocale is doing
> > exactly what it is meant to do, but the unexpected side-effects are
> > catching people out.
> >
> > We have libraries that ship with PHP for formatting dates, numbers etc
> > that actually work, and don't break other libraries.
> >
> > So two questions:
> >
> > i) Are there any reasons why we couldn't or shouldn't plan for
> > removing setlocale at some point in the future? i.e. does it do
> > something that isn't supported by other libraries in PHP?
> >
>
> -1
> I don=E2=80=99t hink that we should restrict access to standard library f=
unctions
> just because something might break due to usage under wrong assumptions.
>
> > ii) If it's not possible (or desirable) to remove it, how could we
> > increase the warning level against using it?
>
>
maybe we could try something to mark/warn extension which aren't thread
safe when using in a TS build, but other than that I think it is just an
education/documentation problem.
(and removing something which works without having an alternative is bad in
my book)

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--047d7b4724aced59bb0512ace6b9--