Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
Sender: Michael Wallner <mike.php.net@gmail.com>
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\))
In-Reply-To: <CA+kxMuSvxRq-AvjQSBUc-FiYdTrD_1X2SuQtjWRjTwAbcwWRoA@mail.gmail.com>
Date: Wed, 1 Apr 2015 19:08:13 +0200
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <D3036E76-05FE-4B4A-91E2-BF6B3B079546@php.net>
References: <CA+kxMuSvxRq-AvjQSBUc-FiYdTrD_1X2SuQtjWRjTwAbcwWRoA@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Subject: Re: [PHP-DEV] Deprecate setlocale?
From: mike@php.net (Michael Wallner)


> On 01 04 2015, at 18:15, Dan Ackroyd <danack@basereality.com> wrote:
>=20
> Hi,
>=20
> I'd like to get people's feedback for the idea of making setlocale be
> either deprecated and to be removed eventually or just increasing the
> warning level against people using it.
>=20
> The short version of why we should do this is that setlocale breaks
> things. It is a process wide operation, that is not thread safe on
> most platforms. Although people use it to alter the way strings are
> output, it also breaks libraries that are assuming that they are
> running in a "C" locale.
>=20
> https://bugs.php.net/bug.php?id=3D59571 - breaks Imagick
> https://bugs.php.net/bug.php?id=3D54538 - breaks NumberFormatter
> https://bugs.php.net/bug.php?id=3D66108 - breaks constants
> https://bugs.php.net/bug.php?id=3D67127 - breaks DateTime
> https://bugs.php.net/bug.php?id=3D69348 - breaks MySQL
>=20
> And there are quite a few other bug reports where setlocale is doing
> exactly what it is meant to do, but the unexpected side-effects are
> catching people out.
>=20
> We have libraries that ship with PHP for formatting dates, numbers etc
> that actually work, and don't break other libraries.
>=20
> So two questions:
>=20
> i) Are there any reasons why we couldn't or shouldn't plan for
> removing setlocale at some point in the future? i.e. does it do
> something that isn't supported by other libraries in PHP?
>=20

-1
I don=E2=80=99t hink that we should restrict access to standard library =
functions just because something might break due to usage under wrong =
assumptions.

> ii) If it's not possible (or desirable) to remove it, how could we
> increase the warning level against using it?