Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85618
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.217.169 cause and error)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLvTQ-4Dc5wcXCYouE0fE3Ls8CmZOSWB9xGXd5XHkpNOrg@mail.gmail.com>
References: <CA+kxMuTh4haa=wF8h_gMp+cMocK3sG8sxwZnG=NHCORKi41TYQ@mail.gmail.com>
	<CA+9eiLvH_1itW9fVsv_FoX+MXuWz18XLQvELEimuaoPgAAGBVA@mail.gmail.com>
	<CA+kxMuQPoDDv8CDmCJhiiPJ+rRs0nYFQxy=ZPVWfP-YqFb0Nuw@mail.gmail.com>
	<CA+9eiLsd_i4UNCBGOM=ZUM-MN+CS26cSd2zTD-dHJ4iAm3F=GQ@mail.gmail.com>
	<CAF+90c_u=zMAnGijUAw8aFa5XB=-WK+4Rn1KEa4LMunxVQ3M8Q@mail.gmail.com>
	<CA+9eiLvTQ-4Dc5wcXCYouE0fE3Ls8CmZOSWB9xGXd5XHkpNOrg@mail.gmail.com>
Date: Wed, 1 Apr 2015 01:31:54 +0000
Message-ID: <CA+kxMuSyBun+vr=OXBzNEpoHHvtDthJnteERHknmdGRVGZk0tg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][VOTE] Constructor behaviour of internal classes
From: danack@basereality.com (Dan Ackroyd)

Hi Dmitry,

Your approach is definitely a better one, and I have no objection to
it whatsoever.

Sorry, I was too busy to look deeply at each class but I can't see any problems.

Nikita Popov wrote:
> does that mean that the same code using strict_types=1 mode will start
> throwing TypeException instead of whatever exception type is passed
> to replace_error_handling?

That's going to affect everything isn't it - not just this RFC?

However I think that is the correct behaviour. It more closely
resembles the behaviour that will be seen in userland code, and is
more 'semantically' meaningful i.e. it allows people to tell the cases
between the two types of errors apart.

It probably bears more thinking about though.

cheers
Dan



$formatInfoList = [
    ["en_US", "{0,number,integer} monkeys on {1,number,integer} trees
make {2,number} monkeys per tree"],
    ["en_US", '{this was made intentionally incorrect}'], //valid type
but wrong value
    ["en_US", new StdClass] //wrong type
]


foreach ($formatInfoList as $formatInfo) {
    list($locale, $pattern) = formatInfo;
    try {
        $mf = new MessageFormatter($locale, $pattern);
        echo $mf->format(array(4560, 123, 4560/123));
    }
    catch(IntlException $ie) {
         // A strict type-est person would not want this to catch the case where
         // the wrong type has been passed, as it's not an exception
related to Intl
         // it's an exception related to the type being wrong.
    }
}