Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85609
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.160.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_u=zMAnGijUAw8aFa5XB=-WK+4Rn1KEa4LMunxVQ3M8Q@mail.gmail.com>
References: <CA+kxMuTh4haa=wF8h_gMp+cMocK3sG8sxwZnG=NHCORKi41TYQ@mail.gmail.com>
	<CA+9eiLvH_1itW9fVsv_FoX+MXuWz18XLQvELEimuaoPgAAGBVA@mail.gmail.com>
	<CA+kxMuQPoDDv8CDmCJhiiPJ+rRs0nYFQxy=ZPVWfP-YqFb0Nuw@mail.gmail.com>
	<CA+9eiLsd_i4UNCBGOM=ZUM-MN+CS26cSd2zTD-dHJ4iAm3F=GQ@mail.gmail.com>
	<CAF+90c_u=zMAnGijUAw8aFa5XB=-WK+4Rn1KEa4LMunxVQ3M8Q@mail.gmail.com>
Date: Wed, 1 Apr 2015 00:18:00 +0300
Message-ID: <CA+9eiLvTQ-4Dc5wcXCYouE0fE3Ls8CmZOSWB9xGXd5XHkpNOrg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Dan Ackroyd <danack@basereality.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c29cc02abbc605129c228d
Subject: Re: [PHP-DEV] [RFC][VOTE] Constructor behaviour of internal classes
From: dmitry@zend.com (Dmitry Stogov)

--001a11c29cc02abbc605129c228d
Content-Type: text/plain; charset=UTF-8

hi Nikita,

I don't care about this a lot. I reworked this patch just because it missed
few details, and then found and fixed mistake in ext/intl.
If you think TypeException is better (I think this makes sense), please
implement it on top and commit.

Thanks. Dmitry.

On Tue, Mar 31, 2015 at 11:07 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, Mar 30, 2015 at 6:06 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Dan,
>>
>> The updated patch is at https://github.com/php/php-src/pull/1205
>>
>> The main difference is in ext/intl.
>> If you don't see any problems I can commit it.
>>
>> I didn't think about the classes you missed.
>>
>> Thanks. Dmitry.
>>
>
> I'm wondering, if we implement throwing zpp by using EH_THROW mode, which
> relies on converting warnings to exceptions, does that mean that the same
> code using strict_types=1 mode will start throwing TypeException instead of
> whatever exception type is passed to replace_error_handling? If so, that
> would be pretty weird. Maybe we should just always throw TypeException for
> this? Could also add a zpp flag for doing that as all the code for throwing
> TypeExceptions is already present, we just need to trigger it.
>
> Nikita
>
>

--001a11c29cc02abbc605129c228d--