Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85603
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 77845 invoked from network); 31 Mar 2015 20:07:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 31 Mar 2015 20:07:20 -0000
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.175 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.212.175 mail-wi0-f175.google.com  
Received: from [209.85.212.175] ([209.85.212.175:38687] helo=mail-wi0-f175.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 49/C3-54064-77EFA155 for <internals@lists.php.net>; Tue, 31 Mar 2015 15:07:19 -0500
Received: by wibgn9 with SMTP id gn9so40148781wib.1
        for <internals@lists.php.net>; Tue, 31 Mar 2015 13:07:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=9fUuaUvsY8fj1d8EY1Oyhx/JtmOeJKTO0cUt+bg4JNY=;
        b=wbQyI0sa4qdf40126Uy/6/f6n8vrWY5VjEpPDlY7BI2JdyQ82zo9GziDQPcWGC/2yy
         utHSf1HrXyflxPA8aIRRCSeWYw3xPdqNhkgojEuZWyuyZJ0b3XUKzD18RcAr5sJJG+AG
         VR4Sm/fCo7cazUlrisb7pi8ZQLdiEel0b3EPWPaZF4Zxw8qXoMod9GI44e9lscrDpomK
         wQwC7JjYEuY5YwCoWSDemmvpIQ0kLVQmXR7GnQsb9sxxJGxYbf3sTzSvifPegNro9uZT
         LXTHQuGxfQ/iSf+uyDz4npqf6Y4HyMW+4j5bBaZ5yHVTBpRgTi1oQ1+C1YeS+E2boJlV
         3Yeg==
MIME-Version: 1.0
X-Received: by 10.194.76.69 with SMTP id i5mr78326095wjw.3.1427832436119; Tue,
 31 Mar 2015 13:07:16 -0700 (PDT)
Received: by 10.27.85.216 with HTTP; Tue, 31 Mar 2015 13:07:15 -0700 (PDT)
In-Reply-To: <CA+9eiLsd_i4UNCBGOM=ZUM-MN+CS26cSd2zTD-dHJ4iAm3F=GQ@mail.gmail.com>
References: <CA+kxMuTh4haa=wF8h_gMp+cMocK3sG8sxwZnG=NHCORKi41TYQ@mail.gmail.com>
	<CA+9eiLvH_1itW9fVsv_FoX+MXuWz18XLQvELEimuaoPgAAGBVA@mail.gmail.com>
	<CA+kxMuQPoDDv8CDmCJhiiPJ+rRs0nYFQxy=ZPVWfP-YqFb0Nuw@mail.gmail.com>
	<CA+9eiLsd_i4UNCBGOM=ZUM-MN+CS26cSd2zTD-dHJ4iAm3F=GQ@mail.gmail.com>
Date: Tue, 31 Mar 2015 22:07:15 +0200
Message-ID: <CAF+90c_u=zMAnGijUAw8aFa5XB=-WK+4Rn1KEa4LMunxVQ3M8Q@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Dan Ackroyd <danack@basereality.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb042be275d9505129b251e
Subject: Re: [PHP-DEV] [RFC][VOTE] Constructor behaviour of internal classes
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bb042be275d9505129b251e
Content-Type: text/plain; charset=UTF-8

On Mon, Mar 30, 2015 at 6:06 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Dan,
>
> The updated patch is at https://github.com/php/php-src/pull/1205
>
> The main difference is in ext/intl.
> If you don't see any problems I can commit it.
>
> I didn't think about the classes you missed.
>
> Thanks. Dmitry.
>

I'm wondering, if we implement throwing zpp by using EH_THROW mode, which
relies on converting warnings to exceptions, does that mean that the same
code using strict_types=1 mode will start throwing TypeException instead of
whatever exception type is passed to replace_error_handling? If so, that
would be pretty weird. Maybe we should just always throw TypeException for
this? Could also add a zpp flag for doing that as all the code for throwing
TypeExceptions is already present, we just need to trigger it.

Nikita

--047d7bb042be275d9505129b251e--