Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85495
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZvup18N85B5Y6YApeWWdWsG322AUYnjb5Brc203icFCg@mail.gmail.com>
References: <CABBJUpfPoRHpPUqbYuL93UsY8b8Cdu7uacRJ33z0JUdcLB9Z+A@mail.gmail.com>
 <55142689.2080106@fedoraproject.org> <CAJW__o1bm-wwT71YnRqj36_NWWBU5+Gpim75TrJ5UhBV_vGddQ@mail.gmail.com>
 <CAJW__o2YWsMx7yyPVNNNU9rNY9+5uydMRv9DsUB7RY=9L_4Rjw@mail.gmail.com>
 <CABBJUpeBoxf3oP=qDm2Vhb=T+w=hGw72Y6GNyk_8km_AcKR0fg@mail.gmail.com> <CAGa2bXZvup18N85B5Y6YApeWWdWsG322AUYnjb5Brc203icFCg@mail.gmail.com>
Date: Fri, 27 Mar 2015 14:41:28 +0800
Message-ID: <CABBJUpfP1zZvULQVFmWALpe=qN2_zFeCzAuYKRJXxYvcEF5sSw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Kalle Sommer Nielsen <kalle@php.net>, Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] is_callable and function_exists with disable_functions
From: laruence@php.net (Xinchen Hui)

Hey:



On Fri, Mar 27, 2015 at 1:14 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> On Fri, Mar 27, 2015 at 11:57 AM, Xinchen Hui <laruence@php.net> wrote:
>>
>> On Fri, Mar 27, 2015 at 3:06 AM, Kalle Sommer Nielsen <kalle@php.net>
>> wrote:
>> > Forgot to CC list
>> >
>> >
>> > ---------- Forwarded message ----------
>> > From: Kalle Sommer Nielsen <kalle@php.net>
>> > Date: 2015-03-26 20:06 GMT+01:00
>> > Subject: Re: [PHP-DEV] is_callable and function_exists with
>> > disable_functions
>> > To: Remi Collet <remi@fedoraproject.org>
>> >
>> >
>> > 2015-03-26 16:32 GMT+01:00 Remi Collet <remi@fedoraproject.org>:
>> >>> do you mind if I change the current behavior of is_callable , to
>> >>> return false on this case?
>> >>
>> >> Make sense
>> >>
>> >>> or, at least, change function_exists's behavior instead?
>> >>
>> >> Seems a bad idea.
>> >
>> > I agree with both points here, I think is_callable() should mimic
>> > function_exists() behavior, is this the same case for disable_classes?
>> >
>> yeah. but a little bit different
>>
>> class_exists return trun with disabled classes :<
>>
>> $ sapi/cli/php -d disable_classes=ArrayObject -r
>> "var_dump(class_exists('arrayobject')); new ArrayObject(); "
>> bool(true)
>> PHP Warning:  ArrayObject() has been disabled for security reasons in
>> Command line code on line 1
>>
>> Warning: ArrayObject() has been disabled for security reasons in
>> Command line code on line 1
>
>
> Returning true for is_callable/class_exists even when it isn't usable does
> not make much sense. How about fix them all?

I filed a bug here: https://bugs.php.net/bug.php?id=69315&thanks=4

will make a fix soon

thanks
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/