Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:85473 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38408 invoked from network); 26 Mar 2015 09:34:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Mar 2015 09:34:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=lior.k@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=lior.k@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.214.170 as permitted sender) X-PHP-List-Original-Sender: lior.k@zend.com X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:35085] helo=mail-ob0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 86/64-32247-EB2D3155 for ; Thu, 26 Mar 2015 04:34:54 -0500 Received: by obcjt1 with SMTP id jt1so40899338obc.2 for ; Thu, 26 Mar 2015 02:34:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=8GqBi8zBlgCDyklkRZQrY9abwi59MVMMszCd4wxlxBo=; b=DCNWAGLKAjlJIzdl+Q5y1C2Zo/SWVIBq17gf7CH+O+NJxa04b9EpDsr2MpoDYjVbC1 cdAgRN0SAHKh2KAy1RAQWHI5ClTCL3BPD8MBsFkSMWk3o0B074Rd6+agFG7bkAC/w/3M fGwmq6XxRCMfrrdWi/Zp7mv3voBtyR29AFBLX0WPTOlKtKD4B+iyLN0BwfjFZ+VB99fX Ih5psgT0CedxytvtpgWU7zGNKTBJp3hINvZWcVMmy+cxLzJCXfhf2cZSWYN9E5AKPifG om4w73N+VVJrkvfdFIgxY87q66NbBVm82Dpn1Aq7aYadhJ7fmZZRgyd1j9rUrnfaagLY Oelw== X-Gm-Message-State: ALoCoQnA3dHBNWrlPeA4OO/GvoEeXeXkNtGlp7h4MeHsKitRQ1AJ802naAoe/IuoRe75hDA4luCjca9FewSsGT8oLCJjE7OSR9p0DJIvl18udYYzSIN2MudJ4zsD66yhsUEwrVUOJUlhLxar1ZI2pQjuSS5/NVJxRw== MIME-Version: 1.0 X-Received: by 10.182.241.99 with SMTP id wh3mr11286963obc.81.1427362491419; Thu, 26 Mar 2015 02:34:51 -0700 (PDT) Received: by 10.60.175.234 with HTTP; Thu, 26 Mar 2015 02:34:51 -0700 (PDT) Date: Thu, 26 Mar 2015 11:34:51 +0200 Message-ID: To: PHP internals list Content-Type: multipart/alternative; boundary=001a11c2ea3444661505122dba6d Subject: odbc extension build issues (shared vs. standalone) From: lior.k@zend.com (Lior Kaplan) --001a11c2ea3444661505122dba6d Content-Type: text/plain; charset=UTF-8 Hi, Following Remi's revert of my commit [1] I'd like to suggest a better solution for master which would be introducing --enable-odbc and having the ODBC drivers default to no (similar to DBA). Current problem is fixing build as a standalone (phpize...) breaks support with builds as "./configure ... -with-unixODBC=shared,/usr" For 5.5/5.6 - I'm not sure whether to play with parsing the options to handle "shared" or "shared,[path]" (see example bellow) or just leave the issue to reduce noise for now (we have this for years), although we already did some changes about --with-odbcver . Any thoughts / ideas / objections ? Kaplan p.s. Before playing with these options I'd like to also turn ODBC builds on travis... --- diff --git a/ext/odbc/config.m4 b/ext/odbc/config.m4 index 4caf567..7a1c98e 100644 --- a/ext/odbc/config.m4 +++ b/ext/odbc/config.m4 @@ -452,8 +452,10 @@ PHP_ARG_WITH(unixODBC,, AC_MSG_CHECKING(for unixODBC support) if test "$PHP_UNIXODBC" != "no"; then - if test "$PHP_UNIXODBC" = "yes"; then + if test "$PHP_UNIXODBC" = "yes" || test "$PHP_UNIXODBC" = "shared"; then PHP_UNIXODBC=/usr/local + else + PHP_UNIXODBC=`echo "$PHP_UNIXODBC"|$SED 's/^shared,//'` fi ODBC_INCDIR=$PHP_UNIXODBC/include ODBC_LIBDIR=$PHP_UNIXODBC/$PHP_LIBDIR --- [1] http://git.php.net/?p=php-src.git;a=commitdiff;h=1174b399ad325b630ba202abc6671d8055160b99 --001a11c2ea3444661505122dba6d--