Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85467
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.181 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <5512C718.2020008@gmail.com>
References: <CAF+90c-CbGZ1d3DJSbzPmCbpjm6Pw3qPXQ=CG4XvbaM+528+jQ@mail.gmail.com>
	<66c0cca2453de53bed0328af2732c7bd@mail.gmail.com>
	<50.00.26446.A7E72155@pb1.pair.com>
	<CAGAGxbbpDoanY3Y=jLuij+gfQOOqjncsruKR8k4jEc6UKr9eTQ@mail.gmail.com>
	<5512C718.2020008@gmail.com>
Date: Wed, 25 Mar 2015 15:37:05 +0000
Message-ID: <CAGAGxbZHOX0oJeqGCuh3aBK2BtA3R0X-xi6LBmK6Lyoh29TFfQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e014942e6e80d3105121eab1a
Subject: Re: [PHP-DEV] Deprecate or remove mbstring function overloads in PHP 7
From: cw@daverandom.com (Chris Wright)

--089e014942e6e80d3105121eab1a
Content-Type: text/plain; charset=UTF-8

On 25 March 2015 at 14:32, Rowan Collins <rowan.collins@gmail.com> wrote:

> Chris Wright wrote on 25/03/2015 13:44:
>
>> That said, in the interests of not causing people using this functionality
>> issues with logs full of errors and/or error-related performance issues, I
>> would support having this deprecation set up in such a way that an error
>> is
>> only issued at most once per request - there's no need to issue a
>> deprecation warning at every function call.
>>
>
> I guess the advantage of doing it on each function call is that you see
> which areas of code are relying on the feature, rather than just that it's
> enabled.
>

Indeed, valid point

Maybe we need a smarter way of signalling deprecation in general, because
> it's very all-or-nothing at the moment. But that could possibly be
> implemented as a userland error handler which de-duped errors before
> outputting them.


In this specific case we could modify the behaviour of the value of the ini
setting to make this configurable. As it stands, the value is treated as a
bit mask with three bits that have meaning, we could make the fourth bit
mean "issue an error on every function call" when set, if it's clear then
issue a warning only once during rinit when the value is non-zero.

I realise this is a slightly horrible solution, just throwing it out there
as a possibility. I'd argue that it's not really any *more* horrible than
the feature in general, though.


>
>
> Regards,
> --
> Rowan Collins
> [IMSoP]
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--089e014942e6e80d3105121eab1a--