Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85445
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CAF+90c9B7seGdPdn-7=mxinFVHXU_rvdK_EDouW+A01HWjkWFw@mail.gmail.com>
References: <CA+9eiLsAQPTkVuR=D0wXMFXhBNM8DQzGq0DRXzSuL+hjPsUpgA@mail.gmail.com>
 <CAF+90c9Kw0iGxEZkpwbfNV+uZKrnpJ32gz9g257w00G1-rC1JQ@mail.gmail.com>
 <CA+9eiLt2tUVJ40_YTVq5TgUWX0a0URvmYwFQU=33nxManhXsng@mail.gmail.com> <CAF+90c9B7seGdPdn-7=mxinFVHXU_rvdK_EDouW+A01HWjkWFw@mail.gmail.com>
Date: Tue, 24 Mar 2015 19:58:22 +0800
Message-ID: <CABBJUpfYC52JkPxMNPsBbspao+Q21RH-msvv5kh4zzyahp3dGw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Dmitry Stogov <dmitry@zend.com>, Joe Watkins <pthreads@pthreads.org>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: Use "ropes" for string concatenation
From: xinchen.h@zend.com (Xinchen Hui)

Hey:

On Tue, Mar 24, 2015 at 7:51 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>> I thought about something like this :)
>> In my opinion UString is really not a proper way to implement Unicoide,
>> but I agree not break anything in current stage.
>> Anyway, please review the first PR (in my opinion it is safe to commit),
>> but you may find some other issues.
>>
>> Thanks. Dmitry.
>
>
> First PR looks okay to me. One question: Why the separate INIT and ADD
> opcodes? They seem pretty much the same, just one using a hardcoded 0
> instead of ex_val.
>
> Regarding exception-safety - is the problem that doing an EG(exception)
> check and releasing the rope is too expensive?
that won't work if :

<?php
function a() {
    throw  new exception($a);
    return "xxx";
}


try {
   $a = "a ${a()} ";
} catch (Exception $a) {

}


thanks
thanks
>
> Nikita



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/