Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85444
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLt2tUVJ40_YTVq5TgUWX0a0URvmYwFQU=33nxManhXsng@mail.gmail.com>
References: <CA+9eiLsAQPTkVuR=D0wXMFXhBNM8DQzGq0DRXzSuL+hjPsUpgA@mail.gmail.com>
	<CAF+90c9Kw0iGxEZkpwbfNV+uZKrnpJ32gz9g257w00G1-rC1JQ@mail.gmail.com>
	<CA+9eiLt2tUVJ40_YTVq5TgUWX0a0URvmYwFQU=33nxManhXsng@mail.gmail.com>
Date: Tue, 24 Mar 2015 12:51:30 +0100
Message-ID: <CAF+90c9B7seGdPdn-7=mxinFVHXU_rvdK_EDouW+A01HWjkWFw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Xinchen Hui <xinchen.h@zend.com>, Joe Watkins <pthreads@pthreads.org>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb042be46f14005120767a7
Subject: Re: Use "ropes" for string concatenation
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bb042be46f14005120767a7
Content-Type: text/plain; charset=UTF-8

On Tue, Mar 24, 2015 at 10:28 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> I thought about something like this :)
> In my opinion UString is really not a proper way to implement Unicoide,
> but I agree not break anything in current stage.
> Anyway, please review the first PR (in my opinion it is safe to commit),
> but you may find some other issues.
>
> Thanks. Dmitry.
>

First PR looks okay to me. One question: Why the separate INIT and ADD
opcodes? They seem pretty much the same, just one using a hardcoded 0
instead of ex_val.

Regarding exception-safety - is the problem that doing an EG(exception)
check and releasing the rope is too expensive?

Nikita

--047d7bb042be46f14005120767a7--