Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85212
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.169 as permitted sender)
MIME-Version: 1.0
References: <CANUQDCjK7F1H5PZeV4XXvbDOsmyYtG4P1fPH3QnKBuY9EM-JdA@mail.gmail.com>
In-Reply-To: <CANUQDCjK7F1H5PZeV4XXvbDOsmyYtG4P1fPH3QnKBuY9EM-JdA@mail.gmail.com>
Date: Thu, 19 Mar 2015 10:51:21 +0000
Message-ID: <CACwt+JeC1FMB4AqAKnDt1m1kxuvz=S6G93Fs8Vd4NJaanSh0aw@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11360a2cfe0bd20511a1fa17
Subject: Re: [PHP-DEV] [RFC][PRE-VOTE] In Operator
From: patrickallaert@php.net (Patrick ALLAERT)

--001a11360a2cfe0bd20511a1fa17
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey,

Le dim. 15 mars 2015 =C3=A0 01:54, Niklas Keller <me@kelunik.com> a =C3=A9c=
rit :

> Morning,
>
> I'd like to announce that I'll open the vote for the in operator later
> that day.
> You can find the RFC here: https://wiki.php.net/rfc/in_operator
>
> There was a small change: If the haystack is a string, integers are no
> longer allowed as needle. This change was necessary so it's
> consistently strict for both, array and string haystacks.
>
> Regards, Niklas
>

If there is one thing that can be improved in a related area: create a true
"Set" datatype.

You just don't imagine how often I encountered bottlenecks in PHP
application where in_array() was used (thousands times per request over not
so small arrays).

Sometimes it can be improved by storing the value in the key part (using an
array to emulate a hash thanks to the internal implementation of arrays),
using SplObjectStorage in case of objects or even a bloom filter
implementation [1]. Visit [2] for some inspirations.

As you see , there is room for improvement to make things easier, but that
wouldn't be by simply be achieved by adding an "in" keyword.

Everytime I see an in_array(), I also cry, but not because of the syntax,
rather because I know how it operates (think: "full table scan" if you were
doing a SELECT query without proper indexes). This simply cannot be
improved in a proper way without a true "Set" implementation.

[1] http://pecl.php.net/package/bloomy
[2]
http://technosophos.com/2009/05/29/set-objects-php-arrays-vs-splobjectstora=
ge.html

Cheers,
Patrick

--001a11360a2cfe0bd20511a1fa17--