Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85168
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.177 as permitted sender)
References: <CAAyV7nEtdFSdPMieK0EvdO+moCqDw7KH59=Lr3+pA10rn=isoQ@mail.gmail.com> <55079692.6050405@gmail.com> <5507E7DD.3010908@lsces.co.uk> <CAPwsocGBHjBtem0UM+-=d8bZ6s44+0f+ACLgKbcNpcuxKwVetw@mail.gmail.com> <E602B239-95F0-42CE-9978-B92C8F8F92EA@ez.no> <CAGa2bXbMhehAz+0ORLFk2F1hGJ0dOcN3HejYd1_DFVXJCvn+uQ@mail.gmail.com> <CAEZPtU5TgZ8_phTYrvmBvHXbG=cCMgdvxni_oF9CogOhL2nXHw@mail.gmail.com> <CAGa2bXZA+JpO7meJ3P8muphZnSo35ovR0kyk-_PV5Y8zhJ16_g@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAGa2bXZA+JpO7meJ3P8muphZnSo35ovR0kyk-_PV5Y8zhJ16_g@mail.gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <2518BE21-5B44-4BAA-80E7-F358AF575C5A@gmail.com>
Cc: Pierre Joye <pierre.php@gmail.com>,
 PHP internals <internals@lists.php.net>, Leigh <leight@gmail.com>,
 =?utf-8?Q?Andr=C3=A9_R=C3=B8mcke?= <andre.romcke@ez.no>,
 Lester Caine <lester@lsces.co.uk>
Date: Wed, 18 Mar 2015 18:46:22 +1100
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Subject: Re: [PHP-DEV] [RFC][Accepted] Scalar Type Declarations V0.5
From: davidkmuir@gmail.com (David Muir)



> On 18 Mar 2015, at 3:44 pm, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>=20
> Hi Pierre,
>=20
>> On Wed, Mar 18, 2015 at 1:35 PM, Pierre Joye <pierre.php@gmail.com> wrote=
:
>>=20
>>> On Mar 18, 2015 11:26 AM, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:
>>>=20
>>> I didn't have my time to spent for the patch. So I don't verify this
>>> by myself, but it seems common sense for this RFC.
>>=20
>> So you voted against it without knowing how it actually works or aims to
>> work? I suggest you to do it now then, before going further with this
>> discussion :)
> I know we are better to play with patch before vote.
> I played with Zeev's patch and I was sure it's better ;)
>=20
> How many of voters spend enough time for both patches before vote?
>=20
> The reason I admit that I didn't spent time to play with the patch is
> following behavior does not make sense to me much and I have
> doubt for it.
>=20
> lib.php:
> <?php
>        declare(strict_types =3D 1);
>        function foo(int $a) {
>        // no function call here
>        }
> ?>
> The declare here does just nothing.

Correct. There are no function calls in the file, so there's nothing for dec=
lare strict to act on.

>=20
> <?php
>        require "lib.php";
>        foo("123"); // will work
> ?>
>=20
> <?php
>        declare(strict_types =3D 1);
>        require "lib.php";
>        foo("123"); // will give an error
> ?>
>=20
> Could someone knowledgeable shed light on this?
>=20
> Regards,
>=20
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net

Shed light on what exactly? Why it behaves this way?

The second file passes because it is in the default weak mode, so it will co=
erce to an int, so the type hint is satisfied.

The third file will error because you have asked it to error when you pass t=
he wrong scalar type to a function.

David=