Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85163
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.175 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <E602B239-95F0-42CE-9978-B92C8F8F92EA@ez.no>
References: <CAAyV7nEtdFSdPMieK0EvdO+moCqDw7KH59=Lr3+pA10rn=isoQ@mail.gmail.com>
 <55079692.6050405@gmail.com> <5507E7DD.3010908@lsces.co.uk>
 <CAPwsocGBHjBtem0UM+-=d8bZ6s44+0f+ACLgKbcNpcuxKwVetw@mail.gmail.com> <E602B239-95F0-42CE-9978-B92C8F8F92EA@ez.no>
Date: Wed, 18 Mar 2015 13:25:38 +0900
Message-ID: <CAGa2bXbMhehAz+0ORLFk2F1hGJ0dOcN3HejYd1_DFVXJCvn+uQ@mail.gmail.com>
To: =?UTF-8?B?QW5kcsOpIFLDuG1ja2U=?= <andre.romcke@ez.no>
Cc: Leigh <leight@gmail.com>, Lester Caine <lester@lsces.co.uk>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1140b2321288280511887cab
Subject: Re: [PHP-DEV] [RFC][Accepted] Scalar Type Declarations V0.5
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1140b2321288280511887cab
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Andre,

On Wed, Mar 18, 2015 at 8:53 AM, Andr=C3=A9 R=C3=B8mcke <andre.romcke@ez.no=
> wrote:

> TL;DR;  weak mode is for api consumers, aka normal php users, while stric=
t
> is
>  for the actual target users of this features: api (library/framework)
> creators.
>

How could it possible?

On Mon, Mar 16, 2015 at 2:49 PM, Dennis Birkholz <dennis@birkholz.biz>
 wrote:

> Am 16.03.2015 um 06:28 schrieb Xinchen Hui:
> >      lib.php
> >      <?php
> >        declare(strict_types =3D 1);
> >        function add(int $a, int $b) {
> >        }
> >
> >      <?php
> >       add($_GET['a'], $_GET['b']);
> >
> >      that means, I need to add a lots of (int) while I try to call a
> > function in a library which is not written by myself.
>
> that is not right and has been discussed a thousand times over.
> The declare changes the rules only for function calls in the file it is
> declared in.
>
> so:
> lib.php:
> <?php
>         declare(strict_types =3D 1);
>         function foo(int $a) {
>         // no function call here
>         }
> ?>
> The declare here does just nothing.
>
> <?php
>         require "lib.php";
>         foo("123"); // will work
> ?>
>
> <?php
>         declare(strict_types =3D 1);
>         require "lib.php";
>         foo("123"); // will give an error
> ?>
>
> Very easy, explained a thousand times over. Bringing up the same false
> arguments up again and again does really not help the discussion.
>

I didn't have my time to spent for the patch. So I don't verify this
by myself, but it seems common sense for this RFC.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1140b2321288280511887cab--