Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85145
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ralphschindler.com from 209.85.214.182 cause and error)
Message-ID: <550899A3.7050705@ralphschindler.com>
Date: Tue, 17 Mar 2015 16:16:19 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Michael Wallner <mike@php.net>, 
 PHP Internals List <internals@lists.php.net>
References: <55084052.4040406@ralphschindler.com> <55086983.4050803@php.net>
In-Reply-To: <55086983.4050803@php.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] phar_rename_archive() bug fix for PHP7
From: ralph@ralphschindler.com (Ralph Schindler)

> I recently stumbled over that issue, too; thanks for looking into it.
>
> Looking at the patch, it seems, that some handling for bzip2 archives is
> missing; I think if there are special cases for .tar, .tgz and .zip,
> there should also be a case for .tbz2 (.tar.bz2).

Yep, I discussed this with a friend and did a quick search this morning. 
  It is missing, mostly because I didn't know how popular .tbz2 was as a 
file extension - it is very rare.  In most cases I see .tar.bz2 (a case 
already handled by .tar).  I can add .tbz2 as a handled file extension, 
and restructure the code accordingly.

Additionally, I've found that phar_detect_phar_fname_ext() also needs 
some suffix validation, which I will also add.

I will have a new commit for this in place tonight. (Which will also 
trigger Travis to run again, I think it failed b/c I force pushed my 
last commit).

Thanks for taking the time, I'll let you know when there are more 
commits to review.

-ralph