Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85139
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.45 as permitted sender)
Message-ID: <55089BF1.2060203@gmail.com>
Date: Tue, 17 Mar 2015 14:26:09 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Patrick Schaaf <php@bof.de>, internals@lists.php.net
References: <1807379.geZHnrMSPX@rofl>
In-Reply-To: <1807379.geZHnrMSPX@rofl>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP apache2handler virtual() function
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> i.e. when it works at all. With Apache 2.4 the ap_rflush() in zif_virtual() 
> terminates the currently running main request, in my testing, resulting in a 
> completely crashing apache. This might be remedied, though.
> 
> At the moment, as part of my efforts to fix bug 68486, I have modified things 
> to that the PHP interpreter is NEVER reentered. virtual() continues to work, 
> but only with URIs that do not again enter the apache2handler.
> 
> First question here: would this be an acceptable bugfix?

Do you mean that you can call virtual() only on non-php URLs but on PHP
urls it would fail? I'd assume that is a pretty big BC break then so
it'd be better if we could avoid it. But if it's not avoidable then I
guess we should do what we need to avoid crashing.

> Furthermore, I have a working prototype of changing the behaviour of virtual() 
> in the following way: _remember_ which subrequest should be made, but then 
> only really make it when the current request ends (php_handler() in the 

That's probably useful but not the case for virtual(), as virtual() is
meant to be replacement for SSI #include, i.e. work in-place, and if
it's deferred till the end of the request the output will be broken.

I'm not sure how many people actually use virtual() (it's pretty limited
use case) but ones that do probably need it to work in place. Not sure
PHP support in it is required though (since you could include PHP code
directly I presume).
-- 
Stas Malyshev
smalyshev@gmail.com