Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85128
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.53 as permitted sender)
Sender: Michael Wallner <mike.php.net@gmail.com>
Message-ID: <55086983.4050803@php.net>
Date: Tue, 17 Mar 2015 18:50:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Ralph Schindler <ralph@ralphschindler.com>, 
 PHP Internals List <internals@lists.php.net>
References: <55084052.4040406@ralphschindler.com>
In-Reply-To: <55084052.4040406@ralphschindler.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] phar_rename_archive() bug fix for PHP7
From: mike@php.net (Michael Wallner)

On 17/03/15 15:55, Ralph Schindler wrote:
> hi all,
> 
> Phar::convertTo*() methods have a design flaw such that phar files can't
> be successfully converted and retain the proper file suffix at the same
> time when the base name contains dots.  An expression of this is
> attempting to convert something-v3.0.0.phar to say a tar.gz via
> convertToExecutable(Phar::TAR, Phar::GZ);
> 
> My original patch respected BC when it was destined for PHP5, but now
> I've cleaned it up and removed the retention of BC behavior, and I
> intend it to be merged to PHP7 only.  As such, existing tests also
> needed modification.
> 
> I'd like some discussion, code review ... and if no objections, some
> karma to commit this to master.  The PR is here:
> 
> https://github.com/php/php-src/pull/297

Hi Ralph!

I recently stumbled over that issue, too; thanks for looking into it.

Looking at the patch, it seems, that some handling for bzip2 archives is
missing; I think if there are special cases for .tar, .tgz and .zip,
there should also be a case for .tbz2 (.tar.bz2).

-- 
Regards,
Mike