Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85125
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ralphschindler.com from 209.85.214.175 cause and error)
Message-ID: <55084052.4040406@ralphschindler.com>
Date: Tue, 17 Mar 2015 09:55:14 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: phar_rename_archive() bug fix for PHP7
From: ralph@ralphschindler.com (Ralph Schindler)

hi all,

Phar::convertTo*() methods have a design flaw such that phar files can't 
be successfully converted and retain the proper file suffix at the same 
time when the base name contains dots.  An expression of this is 
attempting to convert something-v3.0.0.phar to say a tar.gz via 
convertToExecutable(Phar::TAR, Phar::GZ);

My original patch respected BC when it was destined for PHP5, but now 
I've cleaned it up and removed the retention of BC behavior, and I 
intend it to be merged to PHP7 only.  As such, existing tests also 
needed modification.

I'd like some discussion, code review ... and if no objections, some 
karma to commit this to master.  The PR is here:

https://github.com/php/php-src/pull/297

Thanks,
Ralph