Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85123
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.198 cause and error)
Message-ID: <55082C50.7080100@fedoraproject.org>
Date: Tue, 17 Mar 2015 14:29:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <20150317141242.Horde.Y2OkqMHX5SvXsTYAINC7tER@neo.wg.de>
In-Reply-To: <20150317141242.Horde.Y2OkqMHX5SvXsTYAINC7tER@neo.wg.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Streams BC break unfixed since 5.6.5
From: remi@fedoraproject.org (Remi Collet)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 17/03/2015 14:12, Jan Schneider a =C3=A9crit :
> Hello,
>=20
> now that RFCing has settled down a bit, and things should get back
> to more development and less politics, can someone please take a
> look at this regression: https://bugs.php.net/bug.php?id=3D68948 that
> has a PR here: https://github.com/php/php-src/pull/1153
>=20
> This BC breaking regression is breaking real world applications
> since two 5.5 and 5.6 releases (http://3v4l.org/YJRWQ) and the fix
> is ready to merge, at least to the master branch.

For memory, this have been detected during 5.5.21RC on Jan 11th and
reported to internal

http://news.php.net/php.internals/80363
http://news.php.net/php.internals/80410

And also reported to affected projects, i.e. Guzzle and Horde (Jan 10th)

Answer from horde developer (slusarz):

> I think the current (fixed) behavior is correct.
>=20
> My implementation of the filter was actually wrong in that it
> assumed that the filter would only be called once with a single
> bucket.  From a practical standpoint, this didn't make a difference
> because strings that we need to quote, at least in
> Horde_Imap_Client, are so short (< 50 characters) that the filter
> never saw more than 1 bucket in everyday usage.  But theoretically,
> if someone was using the filter to quote a long string, the
> previous Horde_Imap_Client_Data_Format_Filter_Quote would have been
> broken before my fix.

I'm very disappointed by this, by the lack of interested by my initial
"heads-up" message, by lack of reaction from upstream project, and
this very late request for revert.


Remi.

>=20
> Thanks for looking into this, Jan.
>=20

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlUILFAACgkQYUppBSnxahhtqQCg525E7cZvIPB6XIv0ux/YRkst
9TAAoPU2qLdlyNo98EKK8EkuHrPZ7d+r
=3DBSgH
-----END PGP SIGNATURE-----