Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85086
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.52 as permitted sender)
References: <CAFp73XvmrZ3VTEHAoUAMgFbK1Sx5D4CdQpT9e9+=HQUBFGNuKw@mail.gmail.com> <55033D61.8050405@lsces.co.uk> <CFD2AB9E-E72F-4D2A-94E0-92CA13D5F155@gmail.com> <DUB113-W1388DE29A133134FAAF3A62F9020@phx.gbl>
Mime-Version: 1.0 (1.0)
In-Reply-To: <DUB113-W1388DE29A133134FAAF3A62F9020@phx.gbl>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-0151E4EC-5A21-4A1A-A9DB-79997D992EB0
Content-Transfer-Encoding: 7bit
Message-ID: <A6F8ED9C-AF4E-4626-897F-2999689A843D@gmail.com>
Cc: Lester Caine <lester@lsces.co.uk>,
 "internals@lists.php.net" <internals@lists.php.net>
Date: Tue, 17 Mar 2015 07:06:34 +1100
To: Thomas Punt <tpunt@hotmail.co.uk>
Subject: Re: [PHP-DEV] STH and the 3 RFCs
From: davidkmuir@gmail.com (David Muir)

--Apple-Mail-0151E4EC-5A21-4A1A-A9DB-79997D992EB0
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable


> On 17 Mar 2015, at 1:33 am, Thomas Punt <tpunt@hotmail.co.uk> wrote:
>=20
> Hey David,
>> A library written in weak or strict mode will have no bearing on its publ=
ic API.
>=20
> Strictly speaking (pun intended), this is not true. A library can easily e=
xpose a
> facade that enforces a user of that library (who is in weak mode) to have t=
o write
> in strict mode [1]. Once more, this can be done unintentionally [2] becaus=
e of the
> caller-deciding semantics. These examples can be further extended into wra=
pper
> classes, nested library dependencies, etc.
>=20
> Sure, you could argue that this could easily be turned off by simply remov=
ing the
> top declare() statement of that library, but modifying the library in itse=
lf introduces
> complications - especially when using dependency managers like Composer.
>=20
> [1] https://gist.github.com/tpunt/4830d18d47e2df021c2f
> [2] https://gist.github.com/tpunt/eecfed2495bdccb73632
>=20
> -Tom              =20

No, your example would blow up regardless of the caller being in strict mode=
 or weak mode. The calls made in the library are strict, and will always fai=
l with bad input. All you've shown is that poor code will blow up with poor i=
nput validation.

If you had:
<?php
declare(strict_types=3D1);
require 'library.php';
(new LibraryFacade)->test('1');

It would still error just as before.

Cheers,
David=

--Apple-Mail-0151E4EC-5A21-4A1A-A9DB-79997D992EB0--