Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85084
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXatvGGeM6_aa7zbTDupoPHCP_J-C=Q6u-PM6mDm41iNzQ@mail.gmail.com>
References: <CABBJUpfiy1BpdyZ5MJmQb3vQz9U8TkSECHCRctupV+BUG1H=fw@mail.gmail.com>
	<55066F07.80308@birkholz.biz>
	<CAGa2bXatvGGeM6_aa7zbTDupoPHCP_J-C=Q6u-PM6mDm41iNzQ@mail.gmail.com>
Date: Mon, 16 Mar 2015 15:03:51 -0500
Message-ID: <CALrkBjYW_en+AKCSdCwYJyg9DFOVUzCi=1Yqe11L1HyYg2mNAg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Dennis Birkholz <dennis@birkholz.biz>, 
	"internals@lists.php.net >> 'PHP Internals'" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=90e6ba614e705d909c05116d593b
Subject: Re: [PHP-DEV] About declare(strict_types = 1)
From: pencap@gmail.com (Mike Willbanks)

--90e6ba614e705d909c05116d593b
Content-Type: text/plain; charset=UTF-8

On Mon, Mar 16, 2015 at 2:12 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> On Mon, Mar 16, 2015 at 2:49 PM, Dennis Birkholz <dennis@birkholz.biz>
> wrote:
>
> > Am 16.03.2015 um 06:28 schrieb Xinchen Hui:
> > >      lib.php
> > >      <?php
> > >        declare(strict_types = 1);
> > >        function add(int $a, int $b) {
> > >        }
> > >
> > >      <?php
> > >       add($_GET['a'], $_GET['b']);
> > >
> > >      that means, I need to add a lots of (int) while I try to call a
> > > function in a library which is not written by myself.
> >
> > that is not right and has been discussed a thousand times over.
> > The declare changes the rules only for function calls in the file it is
> > declared in.
> >
> > so:
> > lib.php:
> > <?php
> >         declare(strict_types = 1);
> >         function foo(int $a) {
> >         // no function call here
> >         }
> > ?>
> > The declare here does just nothing.
> >
> > <?php
> >         require "lib.php";
> >         foo("123"); // will work
> > ?>
> >
> > <?php
> >         declare(strict_types = 1);
> >         require "lib.php";
> >         foo("123"); // will give an error
> > ?>
> >
>
> If this kind of behavior is allowed, why "strict mode" is strict? It's not
> strict at all if mode could be overridden.
>
> "strict_mode" is just controlling errors, then it should be handled as
> error E_WARNING/E_TYPE or whatever.
>
> Even if what it controlling is error that can be overridden by caller, yet
> calling it "strict" is not correct. Proper name would be something
> like "raise_type_error".
>
> Let see how it looks if "strict_types" is renamed to "raise_type_error"
>
> <?php
>         declare(raise_type_error = 1);
>         function foo(int $a) {
>         // no function call here
>         }
> ?>
> The declare here does just nothing.
>
> <?php
>         require "lib.php";
>         foo("123"); // will work
> ?>
>
> <?php
>         declare(raise_type_error = 1);
>         require "lib.php";
>         foo("123"); // will give an error
> ?>
>
> Is everyone feel OK with this??
>


That seems far more odd in my opinion.  I vastly prefer the first.

--90e6ba614e705d909c05116d593b--