Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85070
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpenkCnGsQPb8eWoPMG+Wz0SPeuaUxJccpCY+uUVPTsBuQ@mail.gmail.com>
References: <60525DAED8264509BF14D25637CD7C1E@gmail.com> <CAPg3XxKqmfeZOS0Qusr1WNPgE1qKnnYRGr0MjpNcTSxF19vxhg@mail.gmail.com>
 <CABBJUpenkCnGsQPb8eWoPMG+Wz0SPeuaUxJccpCY+uUVPTsBuQ@mail.gmail.com>
Date: Mon, 16 Mar 2015 15:32:05 +0000
Message-ID: <CAPg3Xx+EjaWGrSyVNGejyJOk75zP5MV4geU_PKEGss2gQESjmA@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: Wei Dai <zxcvdavid@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e010d833ccd88f20511698f2b
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function
From: petercowburn@gmail.com (Peter Cowburn)

--089e010d833ccd88f20511698f2b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 16 March 2015 at 14:59, Xinchen Hui <laruence@php.net> wrote:

> Hey:
>
> On Mon, Mar 16, 2015 at 5:45 PM, Peter Cowburn <petercowburn@gmail.com>
> wrote:
> > On 16 March 2015 at 01:40, Wei Dai <zxcvdavid@gmail.com> wrote:
> >
> >> Hi internals,
> >>
> >> The RFC to add a user-land function for an easy-to-use and reliable
> >> preg_replace_callback_array() in PHP is up for discussion:
> >> https://wiki.php.net/rfc/preg_replace_callback_array
> >>
> >> This proposes adding one function: `preg_replace_callback_array()` tha=
t
> >> is the better way to Implement when there are multiple patterns need t=
o
> >> replace.
> >>
> >> I would love to hear your feedback! :)
> >>
> >
> > Could you add a paragraph or two explaining the reasons for choosing th=
is
> > particular proposal?
> > Some examples of what I would like to read:
> >  - why we can't do preg_replace_callback($array_of_regexes,
> > $array_of_callbacks, $subject)
> array() also could be a valid callback.. (array("clasname", "methodname")=
).
> >  - why not preg_replace_callback($array_of_regex_to_callback_pairs,
> > $subject)
> there are also $limit, $count argument could be used.
> >  - why not pass the regex used to the callback, as per Laruence's earli=
er
> > RFC
> bc break..(change the callback's signature)
> >
> > And give a few links to historical discussions in the same sort of area=
?
> > E.g Laruence's RFC: https://wiki.php.net/rfc/second_arg_to_preg_callbac=
k
> and
> > its discussion thread (http://php.markmail.org/thread/qwiyq5o2vwlbdczq)=
.
> >
> thanks
>

In case my earlier message wasn't clear, I was asking for the RFC itself to
be padded out with those sorts of details. The reason being, many (most)
people won't be already familiar with the surrounding discussions that have
happened previously, or the reasons for the potentially strange-seeming
design choices made in this RFC.


> >
> >
> >
> >> Any objections?
> >>
> >>
> >> =E2=80=94
> >> Best,
> >> Wei Dai
> >>
> >>
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--089e010d833ccd88f20511698f2b--