Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:85048
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.160.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAOsHV+sPxmfXWD-Lvg39jPu+dzYR_PMx3EpnYih=wO1eUM_ebw@mail.gmail.com>
References: <CAOsHV+uYLVuOhva_wpyGouHg5c8+ajko0m8CN1aU2HARcyga3A@mail.gmail.com>
	<CAOsHV+s8WFbAVgQXnSJWHzPTLKQnMZUktO5-5bsBZ8a=AhhHQg@mail.gmail.com>
	<CA+kxMuSmd30hOQAnfXjXF7io_aEM4aCnTGigYuF0KZeDarz3bQ@mail.gmail.com>
	<CAOsHV+sPxmfXWD-Lvg39jPu+dzYR_PMx3EpnYih=wO1eUM_ebw@mail.gmail.com>
Date: Mon, 16 Mar 2015 12:41:03 +0000
Message-ID: <CA+kxMuRxNds2P3YxJad00XGr2orv2R793=E2PZzUO4GoFkFzJA@mail.gmail.com>
To: marcio3w@gmail.com
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV][RFC][VOTE] Strict Argument Count On Function Calls
From: danack@basereality.com (Dan Ackroyd)

On 15 March 2015 at 19:19, Marcio Almada <marcio.web2@gmail.com> wrote:
> Hi
>> It's also going to be impossible for people to try the patch out, or
>> to measure it for performance hit.
>>
>
> Performance has never been an issue with this RFC. You probably meant "bc
> break" not "performance hit", and the suggested change about dynamic calls
> Bob did, if accepted by, is a minor change that will actually reduce the BC
> breaks not enlarge it.


The patch has a pretty major bug in it.

If the function is called dynamically first, and then called
statically the warning is not given. i.e. the code below gives an
error 50% of the time. This is why people need time to evaluate code,
and why opening a vote straight after you've made a change to how the
syntax works is really bad idea.

<?php

function bar($x) {
}

if (rand(0, 1)) {
    $fn = 'bar';
    $fn(4, 5);
}
bar(4, 5);

exit(0);

?>

This was built off your branch with commit
6ca9d912c9aa8361852e979c172e57b011b91c16

cheers
Dan